From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Liran Alon <liran.alon@oracle.com>,
pbonzini@redhat.com, rkrcmar@redhat.com, kvm@vger.kernel.org
Cc: sean.j.christopherson@intel.com, jmattson@google.com,
Liran Alon <liran.alon@oracle.com>,
Mark Kanda <mark.kanda@oracle.com>
Subject: Re: [PATCH] KVM: x86: Unexport kvm_vcpu_reload_apic_access_page()
Date: Tue, 19 Nov 2019 13:30:51 +0100 [thread overview]
Message-ID: <87ftikgi9w.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <20191118172702.42200-1-liran.alon@oracle.com>
Liran Alon <liran.alon@oracle.com> writes:
> The function is only used in kvm.ko module.
>
> Reviewed-by: Mark Kanda <mark.kanda@oracle.com>
> Signed-off-by: Liran Alon <liran.alon@oracle.com>
> ---
> arch/x86/kvm/x86.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index eb992f5d299f..7e7a0921d92a 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -7916,7 +7916,6 @@ void kvm_vcpu_reload_apic_access_page(struct kvm_vcpu *vcpu)
> */
> put_page(page);
> }
> -EXPORT_SYMBOL_GPL(kvm_vcpu_reload_apic_access_page);
>
> void __kvm_request_immediate_exit(struct kvm_vcpu *vcpu)
> {
It doesn't seem that we need the declaration in
arch/x86/include/asm/kvm_host.h either (and the function can become
local). Anyway,
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
--
Vitaly
next prev parent reply other threads:[~2019-11-19 12:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 17:27 [PATCH] KVM: x86: Unexport kvm_vcpu_reload_apic_access_page() Liran Alon
2019-11-19 12:30 ` Vitaly Kuznetsov [this message]
2019-11-19 15:34 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftikgi9w.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=liran.alon@oracle.com \
--cc=mark.kanda@oracle.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox