* [PATCH] KVM: x86: Unexport kvm_vcpu_reload_apic_access_page()
@ 2019-11-18 17:27 Liran Alon
2019-11-19 12:30 ` Vitaly Kuznetsov
2019-11-19 15:34 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Liran Alon @ 2019-11-18 17:27 UTC (permalink / raw)
To: pbonzini, rkrcmar, kvm
Cc: sean.j.christopherson, jmattson, vkuznets, Liran Alon, Mark Kanda
The function is only used in kvm.ko module.
Reviewed-by: Mark Kanda <mark.kanda@oracle.com>
Signed-off-by: Liran Alon <liran.alon@oracle.com>
---
arch/x86/kvm/x86.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index eb992f5d299f..7e7a0921d92a 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -7916,7 +7916,6 @@ void kvm_vcpu_reload_apic_access_page(struct kvm_vcpu *vcpu)
*/
put_page(page);
}
-EXPORT_SYMBOL_GPL(kvm_vcpu_reload_apic_access_page);
void __kvm_request_immediate_exit(struct kvm_vcpu *vcpu)
{
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM: x86: Unexport kvm_vcpu_reload_apic_access_page()
2019-11-18 17:27 [PATCH] KVM: x86: Unexport kvm_vcpu_reload_apic_access_page() Liran Alon
@ 2019-11-19 12:30 ` Vitaly Kuznetsov
2019-11-19 15:34 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Vitaly Kuznetsov @ 2019-11-19 12:30 UTC (permalink / raw)
To: Liran Alon, pbonzini, rkrcmar, kvm
Cc: sean.j.christopherson, jmattson, Liran Alon, Mark Kanda
Liran Alon <liran.alon@oracle.com> writes:
> The function is only used in kvm.ko module.
>
> Reviewed-by: Mark Kanda <mark.kanda@oracle.com>
> Signed-off-by: Liran Alon <liran.alon@oracle.com>
> ---
> arch/x86/kvm/x86.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index eb992f5d299f..7e7a0921d92a 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -7916,7 +7916,6 @@ void kvm_vcpu_reload_apic_access_page(struct kvm_vcpu *vcpu)
> */
> put_page(page);
> }
> -EXPORT_SYMBOL_GPL(kvm_vcpu_reload_apic_access_page);
>
> void __kvm_request_immediate_exit(struct kvm_vcpu *vcpu)
> {
It doesn't seem that we need the declaration in
arch/x86/include/asm/kvm_host.h either (and the function can become
local). Anyway,
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
--
Vitaly
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM: x86: Unexport kvm_vcpu_reload_apic_access_page()
2019-11-18 17:27 [PATCH] KVM: x86: Unexport kvm_vcpu_reload_apic_access_page() Liran Alon
2019-11-19 12:30 ` Vitaly Kuznetsov
@ 2019-11-19 15:34 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2019-11-19 15:34 UTC (permalink / raw)
To: Liran Alon, rkrcmar, kvm
Cc: sean.j.christopherson, jmattson, vkuznets, Mark Kanda
On 18/11/19 18:27, Liran Alon wrote:
> The function is only used in kvm.ko module.
>
> Reviewed-by: Mark Kanda <mark.kanda@oracle.com>
> Signed-off-by: Liran Alon <liran.alon@oracle.com>
> ---
> arch/x86/kvm/x86.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index eb992f5d299f..7e7a0921d92a 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -7916,7 +7916,6 @@ void kvm_vcpu_reload_apic_access_page(struct kvm_vcpu *vcpu)
> */
> put_page(page);
> }
> -EXPORT_SYMBOL_GPL(kvm_vcpu_reload_apic_access_page);
>
> void __kvm_request_immediate_exit(struct kvm_vcpu *vcpu)
> {
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-19 15:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-18 17:27 [PATCH] KVM: x86: Unexport kvm_vcpu_reload_apic_access_page() Liran Alon
2019-11-19 12:30 ` Vitaly Kuznetsov
2019-11-19 15:34 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox