From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6601E33D6ED for ; Mon, 23 Mar 2026 07:24:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774250664; cv=none; b=gndRiEqmAunY4+n7sS4oxKXMi71jmFybOWn00jM4YcXETEApcPyJ2FtZfBJ0f8TfHaqDBEeaqtR2cruVoDwWa/hhi2Em8eWU5PngOAy9g/tRRbRhuFYKoh2EtKbja9YD5hIWrMknzxyE439VeEBO478I51jZGHXXVxAzGzKJKbM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774250664; c=relaxed/simple; bh=AurJgOyGd+wqqhJz+nO8Tc+nKJxem384h3yIw5UNIH8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=cOjZOIWY1j1oaGMLpKdwGd4GhxR6Quq8+RKm4s4s4mggkTpsW3XuQkHr0aFUzUzFejG3B8IfscprSXmnanTJsyDK6Imv/i+IpwDHDhSaqq7HlzzjtGc45ZFZRZVzVfTuEwi1/hx8LvOrcPWo+/9RyZAY4isA4EP39w/0vdM/QOo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Wq39ltQQ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Wq39ltQQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774250662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W5fpN+to2H34GvzMy4uc4/TyuJdurXy6MBQlxOrclng=; b=Wq39ltQQpqivrfZEb0mdJ6G8aJjIYXN5WEbrN+rSnXdIKs9H+mT4AUXWvvDz5Z5HxsoSGq +ExqxST8n2JWIRAKqkGabsv72OLh5botIOmf0WzxXkRVqfvcpbYP66lsFRSsf+FEuVu0Yx 95cV/X9A5U7gZp9Pbt0fvln+knWB/18= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-442-OWGcTqnNM3KvCLrl65zUlQ-1; Mon, 23 Mar 2026 03:24:18 -0400 X-MC-Unique: OWGcTqnNM3KvCLrl65zUlQ-1 X-Mimecast-MFC-AGG-ID: OWGcTqnNM3KvCLrl65zUlQ_1774250657 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D18E91955DB6; Mon, 23 Mar 2026 07:24:16 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.6]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 06544180058B; Mon, 23 Mar 2026 07:24:16 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 9E02F21E6937; Mon, 23 Mar 2026 08:24:13 +0100 (CET) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Cc: Tommaso Califano , qemu-devel@nongnu.org, kvm@vger.kernel.org, Eduardo Habkost , Zhao Liu , Marcelo Tosatti , Eric Blake , Oliver Steffen , Stefano Garzarella , Giuseppe Lettieri , Paolo Bonzini , Luigi Leonardi , Richard Henderson Subject: Re: [PATCH 1/5] i386/sev: Add sev-emulated QOM object with TCG support In-Reply-To: ("Daniel P. =?utf-8?Q?Berrang?= =?utf-8?Q?=C3=A9=22's?= message of "Fri, 20 Mar 2026 12:40:12 +0000") References: <20260317113840.33017-1-califano.tommaso@gmail.com> <20260317113840.33017-2-califano.tommaso@gmail.com> <87eclfj66v.fsf@pond.sub.org> Date: Mon, 23 Mar 2026 08:24:13 +0100 Message-ID: <87h5q7100y.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Daniel P. Berrang=C3=A9 writes: > On Fri, Mar 20, 2026 at 08:44:40AM +0100, Markus Armbruster wrote: >> Daniel P. Berrang=C3=A9 writes: >>=20 >> > On Tue, Mar 17, 2026 at 12:38:36PM +0100, Tommaso Califano wrote: >> >> With this change it is possible to run a VM with the SEV CPUID active >> >> adding: >> >>=20 >> >> -accel tcg \ >> >> -object sev-emulated,id=3Dsev0,cbitpos=3D47,reduced-phys-bits=3D1= \ >> >> -machine memory-encryption=3Dsev0 >> > >> > snip >> > >> >> diff --git a/qapi/qom.json b/qapi/qom.json >> >> index c653248f85..35cda819ec 100644 >> >> --- a/qapi/qom.json >> >> +++ b/qapi/qom.json >> >> @@ -1057,6 +1057,19 @@ >> >> '*handle': 'uint32', >> >> '*legacy-vm-type': 'OnOffAuto' } } >> >>=20=20 >> >> +## >> >> +# @SevEmulatedProperties: >> >> +# >> >> +# Properties for sev-emulated objects. >> >> +# This object functionally emulates AMD SEV hardware via TCG, so >> >> +# it does not require real hardware to run. >> >> +# >> >> +# Since: 10.1.0 >> >> +## >> >> +{ 'struct': 'SevEmulatedProperties', >> >> + 'base': 'SevGuestProperties', >> >> + 'data': {}} >> > >> > This is deriving 'sev-emulated' from 'sev-guest' which means it >> > supports all the properties that 'sev-guest' does, which for >> > the record is: >>=20 >> Uh, I somehow misread the base as SevCommonProperties! Had I read >> correctly, I would've had similar questions. > > Even SevCommonProperties has stuff that's irrelevant for > emulation that I mentioned. Yes. I was too hasty. Glad you spotted it!