From: Markus Armbruster <armbru@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: Pierrick Bouvier <pierrick.bouvier@linaro.org>,
Anthony PERARD <anthony.perard@vates.tech>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Paul Durrant <paul@xen.org>, Peter Xu <peterx@redhat.com>,
alex.bennee@linaro.org,
Harsh Prateek Bora <harshpb@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
Alistair Francis <alistair.francis@wdc.com>,
Richard Henderson <richard.henderson@linaro.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Liu Zhiwei <zhiwei_liu@linux.alibaba.com>,
Nicholas Piggin <npiggin@gmail.com>,
Daniel Henrique Barboza <danielhb413@gmail.com>,
qemu-riscv@nongnu.org, manos.pitsidianakis@linaro.org,
Palmer Dabbelt <palmer@dabbelt.com>,
kvm@vger.kernel.org, xen-devel@lists.xenproject.org,
Stefano Stabellini <sstabellini@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Weiwei Li <liwei1518@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH v5 00/17] make system memory API available for common code
Date: Mon, 17 Mar 2025 16:32:08 +0100 [thread overview]
Message-ID: <87h63rekqv.fsf@pond.sub.org> (raw)
In-Reply-To: <3ce90214-a080-4ae8-86ff-9f8fd20f1733@linaro.org> ("Philippe Mathieu-Daudé"'s message of "Mon, 17 Mar 2025 10:21:00 +0100")
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> Hi,
>
> On 14/3/25 19:39, Pierrick Bouvier wrote:
>> On 3/14/25 11:34, Anthony PERARD wrote:
>>> On Fri, Mar 14, 2025 at 10:33:08AM -0700, Pierrick Bouvier wrote:
>>>> Hi,
>>>>
>>>> one patch is missing review:
>>>> [PATCH v5 12/17] hw/xen: add stubs for various functions.
>>>
>>> My "Acked-by" wasn't enough? Feel free try change it to "Reviewed-by"
>>> instead.
>>>
>> Those are differents. From what I understand, Reviewed implies Acked, but the opposite is not true. If it was, they would be equivalent.
>> Thanks.
>
> IIUC on QEMU Acked-by means "as a maintainer of files modified by
> this patch, I don't have objection on my area, as long as someone
> else takes the patch". It doesn't mean the patch has been reviewed.
>
> Please correct me if I'm wrong.
Documentation/process/submitting-patches.rst has some advice, but not
much. Kernel docs are more thorough, and I believe the information
there applies to QEMU reasonably well:
https://docs.kernel.org/process/5.Posting.html#patch-formatting-and-changelogs
prev parent reply other threads:[~2025-03-17 15:32 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 17:31 [PATCH v5 00/17] make system memory API available for common code Pierrick Bouvier
2025-03-14 17:31 ` [PATCH v5 01/17] exec/tswap: target code can use TARGET_BIG_ENDIAN instead of target_words_bigendian() Pierrick Bouvier
2025-03-14 17:31 ` [PATCH v5 02/17] exec/tswap: implement {ld,st}.*_p as functions instead of macros Pierrick Bouvier
2025-03-14 17:31 ` [PATCH v5 03/17] exec/memory_ldst: extract memory_ldst declarations from cpu-all.h Pierrick Bouvier
2025-03-14 17:31 ` [PATCH v5 04/17] exec/memory_ldst_phys: extract memory_ldst_phys " Pierrick Bouvier
2025-03-14 17:31 ` [PATCH v5 05/17] exec/memory.h: make devend_memop "target defines" agnostic Pierrick Bouvier
2025-03-17 15:48 ` Philippe Mathieu-Daudé
2025-03-17 16:08 ` Pierrick Bouvier
2025-03-14 17:31 ` [PATCH v5 06/17] codebase: prepare to remove cpu.h from exec/exec-all.h Pierrick Bouvier
2025-03-14 17:31 ` [PATCH v5 07/17] exec/exec-all: remove dependency on cpu.h Pierrick Bouvier
2025-03-14 17:31 ` [PATCH v5 08/17] exec/memory-internal: " Pierrick Bouvier
2025-03-14 17:31 ` [PATCH v5 09/17] exec/ram_addr: " Pierrick Bouvier
2025-03-14 17:31 ` [PATCH v5 10/17] system/kvm: make kvm_flush_coalesced_mmio_buffer() accessible for common code Pierrick Bouvier
2025-03-14 17:31 ` [PATCH v5 11/17] exec/ram_addr: call xen_hvm_modified_memory only if xen is enabled Pierrick Bouvier
2025-03-17 15:50 ` Philippe Mathieu-Daudé
2025-03-17 16:07 ` Pierrick Bouvier
2025-03-17 16:22 ` Philippe Mathieu-Daudé
2025-03-17 16:23 ` Philippe Mathieu-Daudé
2025-03-17 17:02 ` Pierrick Bouvier
2025-03-14 17:31 ` [PATCH v5 12/17] hw/xen: add stubs for various functions Pierrick Bouvier
2025-03-14 17:31 ` [PATCH v5 13/17] system/physmem: compilation unit is now common to all targets Pierrick Bouvier
2025-03-14 17:31 ` [PATCH v5 14/17] include/exec/memory: extract devend_big_endian from devend_memop Pierrick Bouvier
2025-03-14 17:31 ` [PATCH v5 15/17] include/exec/memory: move devend functions to memory-internal.h Pierrick Bouvier
2025-03-17 15:52 ` Philippe Mathieu-Daudé
2025-03-14 17:31 ` [PATCH v5 16/17] system/memory: make compilation unit common Pierrick Bouvier
2025-03-14 17:31 ` [PATCH v5 17/17] system/ioport: " Pierrick Bouvier
2025-03-14 17:33 ` [PATCH v5 00/17] make system memory API available for common code Pierrick Bouvier
2025-03-14 18:34 ` Anthony PERARD
2025-03-14 18:39 ` Pierrick Bouvier
2025-03-17 9:21 ` Philippe Mathieu-Daudé
2025-03-17 15:32 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h63rekqv.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=anthony.perard@vates.tech \
--cc=danielhb413@gmail.com \
--cc=david@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=harshpb@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=liwei1518@gmail.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=ysato@users.sourceforge.jp \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox