Re: [RFC kvm-unit-tests PATCH] build: fix .aux.o target building

["Marc Hartmayer" <mhartmay@linux.ibm.com>]

On Thu, Jun 06, 2024 at 01:49 PM +1000, "Nicholas Piggin" <npiggin@gmail.com> wrote:
> On Thu Jun 6, 2024 at 1:07 AM AEST, Marc Hartmayer wrote:
>> On Wed, Jun 05, 2024 at 08:53 PM +1000, "Nicholas Piggin" <npiggin@gmail.com> wrote:
>> > On Wed Jun 5, 2024 at 8:42 PM AEST, Marc Hartmayer wrote:
>> >> On Wed, Jun 05, 2024 at 06:16 PM +1000, Nicholas Piggin <npiggin@gmail.com> wrote:

[…snip…]

>
>
>> But what was also interesting is that if I’m using multiple
>> jobs I don’t see the issue.
>>
>> make clean -j; make -j; make -j # <- the last make has nothing to do
>>
>> if I’m using:
>>
>> make clean -j; make; make -j # <- the last make has something to do…
>>                                   that something that irritates me
>
> This is with s390x? Maybe with parallel make, the target is getting

No, it’s a ppc64 cross-build on x86.

> rebuilt via a different prerequisite that is not a .SECONDARY target?
> Adding %.aux.o in PRECIOUS there should help in that case.

Yes, it helps - that was the reason for my fix :)

>
>> >
>> > Is it better to define explicit targets if we want to keep them, or
>> > add to .PRECIOUS? Your patch would be simpler.
>>
>> Normally, I would say without .PRECIOUS it’s cleaner, but there is
>> already a .PRECIOUS for %.so… So as Andrew has already written
>>
>> .PRECIOUS: %.so %.aux.o
>>
>> should also be fine.
>
> Okay, for a minimal fix I will do that.
>
> Thanks,
> Nick
>
-- 
Kind regards / Beste Grüße
   Marc Hartmayer

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294