Re: [PATCH v2 05/10] DMA, CMA: support arbitrary bitmap granularity

Joonsoo Kim
2014-06-12T07:41:40Z

On Thu, Jun 12, 2014 at 04:08:11PM +0900, Minchan Kim wrote:
> On Thu, Jun 12, 2014 at 12:21:42PM +0900, Joonsoo Kim wrote:
> > ppc kvm's cma region management requires arbitrary bitmap granularity,
> > since they want to reserve very large memory and manage this region
> > with bitmap that one bit for several pages to reduce management overheads.
> > So support arbitrary bitmap granularity for following generalization.
> >
> > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> Acked-by: Minchan Kim <minchan@kernel.org>
>

Thanks.

[snip...]
> > /**
> > * dma_alloc_from_contiguous() - allocate pages from contiguous area
> > * @dev: Pointer to device for which the allocation is performed.
> > @@ -345,7 +372,8 @@ static void clear_cma_bitmap(struct cma *cma, unsigned long pfn, int count)
> > static struct page *__dma_alloc_from_contiguous(struct cma *cma, int count,
> > unsigned int align)
> > {
> > - unsigned long mask, pfn, pageno, start = 0;
> > + unsigned long mask, pfn, start = 0;
> > + unsigned long bitmap_maxno, bitmapno, nr_bits;
>
> Just Nit: bitmap_maxno, bitmap_no or something consistent.
> I know you love consistent when I read description in first patch
> in this patchset. ;-)

Yeah, I will fix it. :)

Thanks.