From: Marc Zyngier <marc.zyngier@arm.com>
To: Christoffer Dall <christoffer.dall@linaro.org>
Cc: "rob.herring@linaro.org" <rob.herring@linaro.org>,
"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Anup Patel <anup.patel@linaro.org>,
"patches@apm.com" <patches@apm.com>,
Ashwin Chaugule <ashwin.chaugule@linaro.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Pranavkumar Sawargaonkar <pranavkumar@linaro.org>
Subject: Re: [PATCH v10 05/12] ARM/ARM64: KVM: Make kvm_psci_call() return convention more flexible
Date: Mon, 28 Apr 2014 15:27:34 +0100 [thread overview]
Message-ID: <87ha5dttpl.fsf@approximate.cambridge.arm.com> (raw)
In-Reply-To: <20140428141743.GG2868@lvm> (Christoffer Dall's message of "Mon, 28 Apr 2014 15:17:43 +0100")
On Mon, Apr 28 2014 at 3:17:43 pm BST, Christoffer Dall <christoffer.dall@linaro.org> wrote:
> On Mon, Apr 21, 2014 at 06:29:59PM +0530, Anup Patel wrote:
>> Currently, the kvm_psci_call() returns 'true' or 'false' based on whether
>> the PSCI function call was handled successfully or not. This does not help
>> us emulate system-level PSCI functions where the actual emulation work will
>> be done by user space (QEMU or KVMTOOL). Examples of such system-level PSCI
>> functions are: PSCI v0.2 SYSTEM_OFF and SYSTEM_RESET.
>>
>> This patch updates kvm_psci_call() to return three types of values:
>> 1) > 0 (success)
>> 2) = 0 (success but exit to user space)
>> 3) < 0 (errors)
>>
>> Signed-off-by: Anup Patel <anup.patel@linaro.org>
>> Signed-off-by: Pranavkumar Sawargaonkar <pranavkumar@linaro.org>
>> Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org>
>
> Marc, do you still have comments on this one?
No, this one is OK:
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny.
next prev parent reply other threads:[~2014-04-28 14:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 12:59 [PATCH v10 00/12] In-kernel PSCI v0.2 emulation for KVM ARM/ARM64 Anup Patel
2014-04-21 12:59 ` [PATCH v10 01/12] KVM: Add capability to advertise PSCI v0.2 support Anup Patel
2014-04-21 12:59 ` [PATCH v10 02/12] ARM/ARM64: KVM: Add common header for PSCI related defines Anup Patel
2014-04-28 14:16 ` Christoffer Dall
2014-04-28 17:13 ` Anup Patel
2014-04-28 17:19 ` Ashwin Chaugule
2014-04-21 12:59 ` [PATCH v10 03/12] ARM/ARM64: KVM: Add base for PSCI v0.2 emulation Anup Patel
2014-04-21 12:59 ` [PATCH v10 04/12] KVM: Documentation: Add info regarding KVM_ARM_VCPU_PSCI_0_2 feature Anup Patel
2014-04-21 12:59 ` [PATCH v10 05/12] ARM/ARM64: KVM: Make kvm_psci_call() return convention more flexible Anup Patel
2014-04-28 14:17 ` Christoffer Dall
2014-04-28 14:27 ` Marc Zyngier [this message]
2014-04-21 13:00 ` [PATCH v10 06/12] KVM: Add KVM_EXIT_SYSTEM_EVENT to user space API header Anup Patel
2014-04-21 13:00 ` [PATCH v10 07/12] ARM/ARM64: KVM: Emulate PSCI v0.2 SYSTEM_OFF and SYSTEM_RESET Anup Patel
2014-04-28 14:34 ` Marc Zyngier
2014-04-28 17:04 ` Anup Patel
2014-04-21 13:00 ` [PATCH v10 08/12] ARM/ARM64: KVM: Emulate PSCI v0.2 AFFINITY_INFO Anup Patel
2014-04-28 14:35 ` Marc Zyngier
2014-04-21 13:00 ` [PATCH v10 09/12] ARM/ARM64: KVM: Emulate PSCI v0.2 MIGRATE_INFO_TYPE and related functions Anup Patel
2014-04-21 13:00 ` [PATCH v10 10/12] ARM/ARM64: KVM: Fix CPU_ON emulation for PSCI v0.2 Anup Patel
2014-04-21 13:00 ` [PATCH v10 11/12] ARM/ARM64: KVM: Emulate PSCI v0.2 CPU_SUSPEND Anup Patel
2014-04-28 14:23 ` Christoffer Dall
2014-04-28 14:40 ` Marc Zyngier
2014-04-21 13:00 ` [PATCH v10 12/12] ARM/ARM64: KVM: Advertise KVM_CAP_ARM_PSCI_0_2 to user space Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ha5dttpl.fsf@approximate.cambridge.arm.com \
--to=marc.zyngier@arm.com \
--cc=anup.patel@linaro.org \
--cc=ashwin.chaugule@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=patches@apm.com \
--cc=pranavkumar@linaro.org \
--cc=rob.herring@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox