From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH v10 05/12] ARM/ARM64: KVM: Make kvm_psci_call() return convention more flexible Date: Mon, 28 Apr 2014 15:27:34 +0100 Message-ID: <87ha5dttpl.fsf@approximate.cambridge.arm.com> References: <1398085206-30555-1-git-send-email-anup.patel@linaro.org> <1398085206-30555-6-git-send-email-anup.patel@linaro.org> <20140428141743.GG2868@lvm> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "rob.herring@linaro.org" , "linaro-kernel@lists.linaro.org" , "kvm@vger.kernel.org" , Anup Patel , "patches@apm.com" , Ashwin Chaugule , "kvmarm@lists.cs.columbia.edu" , "linux-arm-kernel@lists.infradead.org" , Pranavkumar Sawargaonkar To: Christoffer Dall Return-path: In-Reply-To: <20140428141743.GG2868@lvm> (Christoffer Dall's message of "Mon, 28 Apr 2014 15:17:43 +0100") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: kvm.vger.kernel.org On Mon, Apr 28 2014 at 3:17:43 pm BST, Christoffer Dall wrote: > On Mon, Apr 21, 2014 at 06:29:59PM +0530, Anup Patel wrote: >> Currently, the kvm_psci_call() returns 'true' or 'false' based on whether >> the PSCI function call was handled successfully or not. This does not help >> us emulate system-level PSCI functions where the actual emulation work will >> be done by user space (QEMU or KVMTOOL). Examples of such system-level PSCI >> functions are: PSCI v0.2 SYSTEM_OFF and SYSTEM_RESET. >> >> This patch updates kvm_psci_call() to return three types of values: >> 1) > 0 (success) >> 2) = 0 (success but exit to user space) >> 3) < 0 (errors) >> >> Signed-off-by: Anup Patel >> Signed-off-by: Pranavkumar Sawargaonkar >> Reviewed-by: Christoffer Dall > > Marc, do you still have comments on this one? No, this one is OK: Acked-by: Marc Zyngier M. -- Jazz is not dead. It just smells funny.