From: Namhyung Kim <namhyung@kernel.org>
To: Dong Hao <haodong@linux.vnet.ibm.com>
Cc: acme@infradead.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, xiaoguangrong@linux.vnet.ibm.com,
runzhen@linux.vnet.ibm.com
Subject: Re: [PATCH] fix compilation error of perf/core
Date: Tue, 25 Sep 2012 17:50:30 +0900 [thread overview]
Message-ID: <87haqmwko9.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <1348561285-25587-1-git-send-email-haodong@linux.vnet.ibm.com> (Dong Hao's message of "Tue, 25 Sep 2012 16:21:25 +0800")
Hi Dong,
On Tue, 25 Sep 2012 16:21:25 +0800, Dong Hao wrote:
> From: Dong Hao <haodong@linux.vnet.ibm.com>
>
> The newest branch of perf/core should have compilation error!
> Error log includes:
>
> builtin-test.c: In function ‘perf_evsel__test_field’:
> builtin-test.c:1216:6: error:
> variable ‘ret’ set but not used [-Werror=unused-but-set-variable]
> builtin-test.c: In function ‘perf_evsel__tp_sched_test’:
> builtin-test.c:1242:6: error:
> variable ‘ret’ set but not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
> make: *** [builtin-test.o] Error 1
> ---------------------------------------------------------------------
> Fix it by replacing return value from 0 to ret.
> Then this branch can be compiled successfully.
>
> Signed-off-by: Dong Hao <haodong@linux.vnet.ibm.com>
I already sent the same patch:
https://lkml.org/lkml/2012/9/24/689
Thanks for fixing it anyway!
Namhyung
prev parent reply other threads:[~2012-09-25 8:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 8:21 [PATCH] fix compilation error of perf/core Dong Hao
2012-09-25 8:50 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87haqmwko9.fsf@sejong.aot.lge.com \
--to=namhyung@kernel.org \
--cc=acme@infradead.org \
--cc=haodong@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=runzhen@linux.vnet.ibm.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox