From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32CB2C433E2 for ; Tue, 21 Jul 2020 13:59:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0DF5D204EA for ; Tue, 21 Jul 2020 13:59:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ftMqAWN9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728477AbgGUN7N (ORCPT ); Tue, 21 Jul 2020 09:59:13 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:46745 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726412AbgGUN7M (ORCPT ); Tue, 21 Jul 2020 09:59:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595339951; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1XSRxOKWh2EaVf4Y8gn83C3uqoFTDUh2rGXBPh4SjUw=; b=ftMqAWN9K0hEp8KUDhZXRE3OtwnKucOdUjc6Pl5x3e6fCJNUPksBUph0c8Nnemz67BJH/N M0oM7CnbE6ETlFqhKrhLvlG6vY0kk/O5R3uXYBOG+YNDxB4sW+jnTTw97YPUobRxdnTH0l mUVIv2Jl2T0E1eiziWyByV9ou1BBW8I= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-17-NFERO0KRNomV2_e4jlKNkg-1; Tue, 21 Jul 2020 09:59:09 -0400 X-MC-Unique: NFERO0KRNomV2_e4jlKNkg-1 Received: by mail-wr1-f69.google.com with SMTP id b8so13127830wro.19 for ; Tue, 21 Jul 2020 06:59:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=1XSRxOKWh2EaVf4Y8gn83C3uqoFTDUh2rGXBPh4SjUw=; b=uE80opcqs/NF7v2keT0ksWSYCoCdESYBtrDXTcKRKnvHo7EM4Q3iQYOFcn1JZ/dhs+ fRlzmDyLtV8fott28sn06E/7BgtQUMtaauUXbeBCx2aafvAWjxg6h6CZsoTQmY1R9h1k 2XU04o2ET3PP+fp7mVvWMRcPZ3J6A4k5P+2tI5ZO4RTVz3msYTsqtbZr88JmpQF+Kr5q 5qHp018eEsEBijU2dnKgKnzXDC14sNjWBYVNYxehhzEvoNSfLivtuaMluDo+s9QOeBRX WASZU0gMKPl/IS0pXnyi1i+9AZlCnyg0ZZgb6/HLq6x5VPMfiOTfZ1H/LSmmZxxm21Jq vgrQ== X-Gm-Message-State: AOAM530nWmjmVsQ9+YDJq90bzeEKz6g0m4SvVES8M+jFj6SICkj/oWjQ q5qymKuGyMB5emJVPMQ40XH3uR2N4IAFh7/xwgUpphG7ozxGvnDC9qoiwoH5ZLbS+y76uWjMM/m znoCC0YeeGtON X-Received: by 2002:a7b:c14a:: with SMTP id z10mr4031832wmi.19.1595339948083; Tue, 21 Jul 2020 06:59:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyG2A4z6SCsD9epS9EdBWaiWCEjcl6nQH/beMuz+mPDsHK4PgHUf5QKKCHzrdN8fMpih4ZIbA== X-Received: by 2002:a7b:c14a:: with SMTP id z10mr4031815wmi.19.1595339947844; Tue, 21 Jul 2020 06:59:07 -0700 (PDT) Received: from vitty.brq.redhat.com (g-server-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id u84sm3634813wmg.7.2020.07.21.06.59.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2020 06:59:07 -0700 (PDT) From: Vitaly Kuznetsov To: Sean Christopherson Cc: Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini Subject: Re: [PATCH 6/7] KVM: x86: Use common definition for kvm_nested_vmexit tracepoint In-Reply-To: <20200721002717.GC20375@linux.intel.com> References: <20200718063854.16017-1-sean.j.christopherson@intel.com> <20200718063854.16017-7-sean.j.christopherson@intel.com> <87365mqgcg.fsf@vitty.brq.redhat.com> <20200721002717.GC20375@linux.intel.com> Date: Tue, 21 Jul 2020 15:59:06 +0200 Message-ID: <87imehotp1.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Sean Christopherson writes: > On Mon, Jul 20, 2020 at 06:52:15PM +0200, Vitaly Kuznetsov wrote: >> Sean Christopherson writes: >> > +TRACE_EVENT_KVM_EXIT(kvm_nested_vmexit); >> > >> > /* >> > * Tracepoint for #VMEXIT reinjected to the guest >> > diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c >> > index fc70644b916ca..f437d99f4db09 100644 >> > --- a/arch/x86/kvm/vmx/nested.c >> > +++ b/arch/x86/kvm/vmx/nested.c >> > @@ -5912,10 +5912,7 @@ bool nested_vmx_reflect_vmexit(struct kvm_vcpu *vcpu) >> > exit_intr_info = vmx_get_intr_info(vcpu); >> > exit_qual = vmx_get_exit_qual(vcpu); >> > >> > - trace_kvm_nested_vmexit(vcpu, exit_reason, exit_qual, >> > - vmx->idt_vectoring_info, exit_intr_info, >> > - vmcs_read32(VM_EXIT_INTR_ERROR_CODE), >> > - KVM_ISA_VMX); >> > + trace_kvm_nested_vmexit(exit_reason, vcpu, KVM_ISA_VMX); >> > >> > /* If L0 (KVM) wants the exit, it trumps L1's desires. */ >> > if (nested_vmx_l0_wants_exit(vcpu, exit_reason)) >> >> With so many lines removed I'm almost in love with the patch! However, >> when testing on SVM (unrelated?) my trace log looks a bit ugly: >> >> <...>-315119 [010] 3733.092646: kvm_nested_vmexit: CAN'T FIND FIELD "rip"vcpu 0 reason npf rip 0x400433 info1 0x0000000200000006 info2 0x0000000000641000 intr_info 0x00000000 error_code 0x00000000 >> <...>-315119 [010] 3733.092655: kvm_nested_vmexit: CAN'T FIND FIELD "rip"vcpu 0 reason npf rip 0x400433 info1 0x0000000100000014 info2 0x0000000000400000 intr_info 0x00000000 error_code 0x00000000 >> >> ... >> >> but after staring at this for some time I still don't see where this >> comes from :-( ... but reverting this commit helps: > > The CAN'T FIND FIELD blurb comes from tools/lib/traceevent/event-parse.c. > > I assume you are using tooling of some form to generate the trace, i.e. the > issue doesn't show up in /sys/kernel/debug/tracing/trace. If that's the > case, this is more or less ABI breakage :-( > Right you are, the tool is called 'trace-cmd record -e kvm ...' / 'trace-cmd report' but I always thought it's not any different from looking at /sys/kernel/debug/tracing/trace directly. Apparently I was wrong. 'cat /sys/kernel/debug/tracing/trace' seems to be OK, e.g.: qemu-system-x86-20263 [006] .... 75982.292657: kvm_nested_vmexit: vcpu 0 reason hypercall rip 0x40122f info1 0x0000000000000000 info2 0x0000000000000000 intr_info 0x00000000 error_code 0x00000000 -- Vitaly