Re: [RFC PATCH 0/2] make mac programming for virtio net more robust

Rusty Russell
2013-01-11T03:55:45Z

"Michael S. Tsirkin" <mst@redhat.com> writes:

> On Thu, Jan 10, 2013 at 10:45:39PM +0800, akong@redhat.com wrote:
>> From: Amos Kong <akong@redhat.com>
>>
>> Currenly mac is programmed byte by byte. This means that we
>> have an intermediate step where mac is wrong.
>>
>> Second patch introduced a new vq control command to set mac
>> address in one time.
>
> As you mention we could alternatively do it without
> new commands, simply add a feature bit that says that MACs are
> in the mac table.
> This would be a much bigger patch, and I'm fine with either way.
> Rusty what do you think?

Hmm, mac filtering and "my mac address" are not quite the same thing. I
don't know if it matters for anyone: does it? The mac address is abused
for things like identifying machines, etc.

If we keep it as a separate concept, Amos' patch seems to make sense.

Cheers,
Rusty.