Re: [kvm-unit-tests PATCH v1 1/3] s390x/Makefile: snippets: Add separate target for the ELF snippets

Marc Hartmayer
2024-07-29T07:42:07Z

On Mon, Jul 29, 2024 at 09:00 AM +0200, Janosch Frank <frankja@linux.ibm.com> wrote:
> On 6/4/24 1:59 PM, Marc Hartmayer wrote:
>> It's unusual to create multiple files in one target rule, and it's even more
>> unusual to create an ELF file with a `.gbin` file extension first, and then
>> overwrite it in the next step. It might even lead to errors as the input file
>> path is also used as the output file path - but this depends on the objcopy
>> implementation. Therefore, create an extra target for the ELF files and list it
>> as a prerequisite for the *.gbin targets.
>>
>> Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
>
> I've picked this one but it's unlikely that I'll pick the other patches
> in the series. Thanks for improving the makefile and fixing my
> mistakes :)

Thanks for the r-b and fine with me. The other two patches are not as
useful and would make s390x even more different from other architectures
with little to no real benefit.

>
--
Kind regards / Beste Grüße
Marc Hartmayer

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294