Re: [PATCH V4 mlx5-next 12/13] vfio/pci: Expose vfio_pci_aer_err_detected()

Alex Williamson
2021-10-26T22:45:07Z

On Tue, 26 Oct 2021 12:06:04 +0300
Yishai Hadas <yishaih@nvidia.com> wrote:

> Expose vfio_pci_aer_err_detected() to be used by drivers as part of
> their pci_error_handlers structure.
>
> Next patch for mlx5 driver will use it.
>
> Signed-off-by: Yishai Hadas <yishaih@nvidia.com>
> ---
> drivers/vfio/pci/vfio_pci_core.c | 5 +++--
> include/linux/vfio_pci_core.h | 2 ++
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c
> index e581a327f90d..0f4a50de913f 100644
> --- a/drivers/vfio/pci/vfio_pci_core.c
> +++ b/drivers/vfio/pci/vfio_pci_core.c
> @@ -1901,8 +1901,8 @@ void vfio_pci_core_unregister_device(struct vfio_pci_core_device *vdev)
> }
> EXPORT_SYMBOL_GPL(vfio_pci_core_unregister_device);
>
> -static pci_ers_result_t vfio_pci_aer_err_detected(struct pci_dev *pdev,
> - pci_channel_state_t state)
> +pci_ers_result_t vfio_pci_aer_err_detected(struct pci_dev *pdev,
> + pci_channel_state_t state)
> {
> struct vfio_pci_core_device *vdev;
> struct vfio_device *device;
> @@ -1924,6 +1924,7 @@ static pci_ers_result_t vfio_pci_aer_err_detected(struct pci_dev *pdev,
>
> return PCI_ERS_RESULT_CAN_RECOVER;
> }
> +EXPORT_SYMBOL_GPL(vfio_pci_aer_err_detected);

Should it also be renamed to vfio_pci_core_aer_err_detected at the same
time? Thanks,

Alex

>
> int vfio_pci_core_sriov_configure(struct pci_dev *pdev, int nr_virtfn)
> {
> diff --git a/include/linux/vfio_pci_core.h b/include/linux/vfio_pci_core.h
> index ef9a44b6cf5d..768336b02fd6 100644
> --- a/include/linux/vfio_pci_core.h
> +++ b/include/linux/vfio_pci_core.h
> @@ -230,6 +230,8 @@ int vfio_pci_core_match(struct vfio_device *core_vdev, char *buf);
> int vfio_pci_core_enable(struct vfio_pci_core_device *vdev);
> void vfio_pci_core_disable(struct vfio_pci_core_device *vdev);
> void vfio_pci_core_finish_enable(struct vfio_pci_core_device *vdev);
> +pci_ers_result_t vfio_pci_aer_err_detected(struct pci_dev *pdev,
> + pci_channel_state_t state);
>
> static inline bool vfio_pci_is_vga(struct pci_dev *pdev)
> {