From mboxrd@z Thu Jan  1 00:00:00 1970
From: Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH v2 33/41] postcopy: introduce -postcopy and -postcopy-flags option
Date: Fri, 08 Jun 2012 12:52:54 +0200
Message-ID: <87k3zixegp.fsf@elfo.mitica>
References: <cover.1338802190.git.yamahata@valinux.co.jp>
	<cover.1338802190.git.yamahata@valinux.co.jp>
	<5083220e72337d11c2f340b520d03af426577790.1338802192.git.yamahata@valinux.co.jp>
Reply-To: quintela@redhat.com
Mime-Version: 1.0
Content-Type: text/plain
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, owasserm@redhat.com,
	avi@redhat.com, pbonzini@redhat.com, aliguori@us.ibm.com,
	stefanha@gmail.com, dlaor@redhat.com, mdroth@linux.vnet.ibm.com,
	yoshikawa.takuya@oss.ntt.co.jp, benoit.hudzia@gmail.com,
	aarcange@redhat.com, t.hirofuchi@aist.go.jp,
	satoshi.itoh@aist.go.jp
To: Isaku Yamahata <yamahata@valinux.co.jp>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:42724 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757267Ab2FHKxN (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 8 Jun 2012 06:53:13 -0400
In-Reply-To: <5083220e72337d11c2f340b520d03af426577790.1338802192.git.yamahata@valinux.co.jp>
	(Isaku Yamahata's message of "Mon, 4 Jun 2012 18:57:35 +0900")
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Isaku Yamahata <yamahata@valinux.co.jp> wrote:
> This patch prepares for postcopy livemigration.
> It introduces -postcopy option and its internal flag, migration_postcopy.
> It introduces -postcopy-flags for chaging the behavior of incoming postcopy
> mainly for benchmark/debug.

Why do we need postcopy flag?  -incoming should be enough to detect that
we are doing postcopy.

    QLIST_HEAD(, LoadStateEntry) loadvm_handlers =
        QLIST_HEAD_INITIALIZER(loadvm_handlers);
    LoadStateEntry *le, *new_le;
    uint8_t section_type;
    unsigned int v;
    int ret;

    if (qemu_savevm_state_blocked(NULL)) {
        return -EINVAL;
    }

    v = qemu_get_be32(f);
    if (v != QEMU_VM_FILE_MAGIC)
        return -EINVAL;

    v = qemu_get_be32(f);
    if (v == QEMU_VM_FILE_VERSION_COMPAT) {
        fprintf(stderr, "SaveVM v2 format is obsolete and don't work anymore\n");
        return -ENOTSUP;
    }
    if (v != QEMU_VM_FILE_VERSION)
        return -ENOTSUP;

Shouldn't we be able to change some version field here and make the
"recognition of postcopy automatic"?  Having to hack around a new
command line option for each page is not going to be nice.  And about
postcopy flags, if they are for "incoming side", please consider just
sent that flags on the stream as a first field?

Thanks, Juan.