From: Thomas Gleixner <tglx@linutronix.de>
To: Borislav Petkov <bp@alien8.de>, Paolo Bonzini <pbonzini@redhat.com>
Cc: Xin Li <xin@zytor.com>, Sean Christopherson <seanjc@google.com>,
Max Kellermann <max.kellermann@ionos.com>,
hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
kvm@vger.kernel.org, Arnd Bergmann <arnd@kernel.org>
Subject: Re: [PATCH] arch/x86/entry_fred: don't set up KVM IRQs if KVM is disabled
Date: Fri, 16 Feb 2024 23:29:06 +0100 [thread overview]
Message-ID: <87le7kavrh.ffs@tglx> (raw)
In-Reply-To: <20240216214617.GBZc_XqVtMuY9_eWWG@fat_crate.local>
On Fri, Feb 16 2024 at 22:46, Borislav Petkov wrote:
> On Fri, Feb 16, 2024 at 07:31:46AM +0100, Paolo Bonzini wrote:
>> and it seems to be a net improvement to me. The #ifs match in
>> the .h and .c files, and there are no unnecessary initializers
>> in the sysvec_table.
>
> Ok, I'll pick up Max' patch tomorrow and we must remember to tell Linus
> during the merge window about this.
No. Don't.
This pointless #ifdeffery in the vector header needs to vanish from the
KVM tree.
Why would you take the #ifdef mess into tasteful code just because
someone decided that #ifdeffing out constants in a header which is
maintained by other people is a brilliant idea?
The #ifdeffery in the idtentry header is unavoidable and the extra NULL
defines are at the right place and not making the actual code
unreadable.
Thanks,
tglx
prev parent reply other threads:[~2024-02-16 22:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240215133631.136538-1-max.kellermann@ionos.com>
2024-02-15 19:55 ` [PATCH] arch/x86/entry_fred: don't set up KVM IRQs if KVM is disabled Sean Christopherson
2024-02-16 2:10 ` Xin Li
2024-02-16 6:31 ` Paolo Bonzini
2024-02-16 17:41 ` Xin Li
2024-02-16 17:47 ` Xin Li
2024-02-16 21:45 ` Thomas Gleixner
2024-02-16 23:00 ` Max Kellermann
2024-02-17 0:11 ` Thomas Gleixner
2024-02-17 9:52 ` Paolo Bonzini
2024-02-17 22:25 ` Thomas Gleixner
2024-02-16 21:46 ` Borislav Petkov
2024-02-16 22:29 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87le7kavrh.ffs@tglx \
--to=tglx@linutronix.de \
--cc=arnd@kernel.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max.kellermann@ionos.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=sfr@canb.auug.org.au \
--cc=x86@kernel.org \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox