Re: [PATCH v4 5/5] vfio: Fold vfio_virqfd.ko into vfio.ko

Jason Gunthorpe
2022-12-01T15:40:29Z

On Thu, Dec 01, 2022 at 04:22:47PM +0100, Cornelia Huck wrote:
> On Tue, Nov 29 2022, Jason Gunthorpe <jgg@nvidia.com> wrote:
>
> > This is only 1.8k, putting it in its own module is not really
> > necessary. The kconfig infrastructure is still there to completely remove
> > it for systems that are trying for small footprint.
> >
> > Put it in the main vfio.ko module now that kbuild can support multiple .c
> > files.
>
> The biggest difference is that we now always have the vfio-irqfd-cleanup
> wq once the vfio module has been loaded, even if pci or platform have
> not been loaded. I guess that only affects a minority of setups (s390x
> without pci?), and probably doesn't really matter.

Modern wq's are just a little bit of memory, it isn't a big deal

Thanks,
Jason