Re: [PATCH v4 5/5] vfio: Fold vfio_virqfd.ko into vfio.ko

Cornelia Huck
2022-12-01T15:24:10Z

On Tue, Nov 29 2022, Jason Gunthorpe <jgg@nvidia.com> wrote:

> This is only 1.8k, putting it in its own module is not really
> necessary. The kconfig infrastructure is still there to completely remove
> it for systems that are trying for small footprint.
>
> Put it in the main vfio.ko module now that kbuild can support multiple .c
> files.

The biggest difference is that we now always have the vfio-irqfd-cleanup
wq once the vfio module has been loaded, even if pci or platform have
not been loaded. I guess that only affects a minority of setups (s390x
without pci?), and probably doesn't really matter.

>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
> drivers/vfio/Kconfig | 2 +-
> drivers/vfio/Makefile | 4 +---
> drivers/vfio/vfio.h | 13 +++++++++++++
> drivers/vfio/vfio_main.c | 7 +++++++
> drivers/vfio/virqfd.c | 17 +++--------------
> 5 files changed, 25 insertions(+), 18 deletions(-)

Reviewed-by: Cornelia Huck <cohuck@redhat.com>