Re: [PATCH v4 1/5] vfio/pci: Move all the SPAPR PCI specific logic to vfio_pci_core.ko

Alex Williamson
2022-12-02T00:00:21Z

On Thu, 01 Dec 2022 12:34:33 +0100
Cornelia Huck <cohuck@redhat.com> wrote:

> On Tue, Nov 29 2022, Jason Gunthorpe <jgg@nvidia.com> wrote:
>
> > The vfio_spapr_pci_eeh_open/release() functions are one line wrappers
> > around an arch function. Just call them directly and move them into
> > vfio_pci_priv.h. This eliminates some weird exported symbols that don't
>
> Hm, that doesn't seem to match the current patch -- the only change to
> vfio_pci_priv.h is removing an empty line :)

s/ and move them into vfio_pci_priv.h//?

> > need to exist.
> >
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> > Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> > ---
> > drivers/vfio/pci/vfio_pci_core.c | 11 +++++++++--
> > drivers/vfio/pci/vfio_pci_priv.h | 1 -
> > drivers/vfio/vfio_spapr_eeh.c | 13 -------------
> > include/linux/vfio.h | 11 -----------
> > 4 files changed, 9 insertions(+), 27 deletions(-)
>