Re: [PATCH v4 2/5] vfio/spapr: Move VFIO_CHECK_EXTENSION into tce_iommu_ioctl()

Cornelia Huck
2022-12-01T11:45:30Z

On Tue, Nov 29 2022, Jason Gunthorpe <jgg@nvidia.com> wrote:

> The PPC64 kconfig is a bit of a rats nest, but it turns out that if
> CONFIG_SPAPR_TCE_IOMMU is on then EEH must be too:
>
> config SPAPR_TCE_IOMMU
> bool "sPAPR TCE IOMMU Support"
> depends on PPC_POWERNV || PPC_PSERIES
> select IOMMU_API
> help
> Enables bits of IOMMU API required by VFIO. The iommu_ops
> is not implemented as it is not necessary for VFIO.
>
> config PPC_POWERNV
> select FORCE_PCI
>
> config PPC_PSERIES
> select FORCE_PCI
>
> config EEH
> bool
> depends on (PPC_POWERNV || PPC_PSERIES) && PCI
> default y
>
> So, just open code the call to eeh_enabled() into tce_iommu_ioctl().
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
> drivers/vfio/vfio_iommu_spapr_tce.c | 10 ++++------
> drivers/vfio/vfio_spapr_eeh.c | 6 ------
> 2 files changed, 4 insertions(+), 12 deletions(-)

Reviewed-by: Cornelia Huck <cohuck@redhat.com>