Re: [PATCH v4 3/5] vfio: Move vfio_spapr_iommu_eeh_ioctl into vfio_iommu_spapr_tce.c

Cornelia Huck
2022-12-01T11:51:08Z

On Tue, Nov 29 2022, Jason Gunthorpe <jgg@nvidia.com> wrote:

> As with the previous patch EEH is always enabled if SPAPR_TCE_IOMMU, so
> move this last bit of code into the main module.
>
> Now that this function only processes VFIO_EEH_PE_OP remove a level of
> indenting as well, it is only called by a case statement that already
> checked VFIO_EEH_PE_OP.
>
> This eliminates an unnecessary module and SPAPR code in a global header.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
> drivers/vfio/Makefile | 1 -
> drivers/vfio/vfio_iommu_spapr_tce.c | 55 +++++++++++++++++-
> drivers/vfio/vfio_spapr_eeh.c | 88 -----------------------------
> include/linux/vfio.h | 12 ----
> 4 files changed, 53 insertions(+), 103 deletions(-)
> delete mode 100644 drivers/vfio/vfio_spapr_eeh.c

Reviewed-by: Cornelia Huck <cohuck@redhat.com>