Re: [PATCH v2 2/4] vfio: Move vfio_spapr_iommu_eeh_ioctl into vfio_iommu_spapr_tce.c

Christoph Hellwig
2022-10-10T07:17:57Z

On Mon, Oct 03, 2022 at 12:39:31PM -0300, Jason Gunthorpe wrote:
> So we don't need to worry about the fact that asm/eeh.h doesn't define
> enough stuff to compile vfio_spapr_iommu_eeh_ioctl() in !CONFIG_EEH. If
> someday someone changes the kconfig around they can also fix the ifdefs in
> asm/eeh.h to compile this code too.

Please just break it up by opencoding the VFIO_CHECK_EXTENSION
cases and just having a helper for VFIO_EEH_PE_OP. I could look
for my patch doing that but again it should be trivial to redo.