From: Markus Armbruster <armbru@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
Valeriy Vdovin <valeriy.vdovin@virtuozzo.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Eric Blake <eblake@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Laurent Vivier <lvivier@redhat.com>,
kvm@vger.kernel.org, Denis Lunev <den@openvz.org>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Subject: Re: [PATCH v12] qapi: introduce 'query-x86-cpuid' QMP command.
Date: Mon, 23 Aug 2021 15:35:14 +0200 [thread overview]
Message-ID: <87lf4scmi5.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <CAOpTY_rv4nZib1Eymm9ZVcLf=v=-QjpUm24U7FtS-1pUqS_6VQ@mail.gmail.com> (Eduardo Habkost's message of "Wed, 11 Aug 2021 09:58:19 -0400")
Eduardo Habkost <ehabkost@redhat.com> writes:
> On Wed, Aug 11, 2021 at 9:44 AM Thomas Huth <thuth@redhat.com> wrote:
>>
>> On 11/08/2021 15.40, Eduardo Habkost wrote:
>> > On Wed, Aug 11, 2021 at 2:10 AM Thomas Huth <thuth@redhat.com> wrote:
>> >>
>> >> On 10/08/2021 20.56, Eduardo Habkost wrote:
>> >>> On Sat, Aug 07, 2021 at 04:22:42PM +0200, Markus Armbruster wrote:
>> >>>> Is this intended to be a stable interface? Interfaces intended just for
>> >>>> debugging usually aren't.
>> >>>
>> >>> I don't think we need to make it a stable interface, but I won't
>> >>> mind if we declare it stable.
>> >>
>> >> If we don't feel 100% certain yet, it's maybe better to introduce this with
>> >> a "x-" prefix first, isn't it? I.e. "x-query-x86-cpuid" ... then it's clear
>> >> that this is only experimental/debugging/not-stable yet. Just my 0.02 €.
>> >
>> > That would be my expectation. Is this a documented policy?
>> >
>>
>> According to docs/interop/qmp-spec.txt :
>>
>> Any command or member name beginning with "x-" is deemed
>> experimental, and may be withdrawn or changed in an incompatible
>> manner in a future release.
>
> Thanks! I had looked at other QMP docs, but not qmp-spec.txt.
>
> In my reply above, please read "make it a stable interface" as
> "declare it as supported by not using the 'x-' prefix".
>
> I don't think we have to make it stable, but I won't argue against it
> if the current proposal is deemed acceptable by other maintainers.
>
> Personally, I'm still frustrated by the complexity of the current
> proposal, but I don't want to block it just because of my frustration.
Is this a case of "there must be a simpler way", or did you actually
propose a simpler way? I don't remember...
next prev parent reply other threads:[~2021-08-23 13:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 12:54 [PATCH v12] qapi: introduce 'query-x86-cpuid' QMP command Valeriy Vdovin
2021-07-28 13:25 ` [PATCH-for-6.2 " Philippe Mathieu-Daudé
2021-08-07 14:22 ` [PATCH " Markus Armbruster
2021-08-10 18:56 ` Eduardo Habkost
2021-08-11 6:09 ` Thomas Huth
2021-08-11 13:40 ` Eduardo Habkost
2021-08-11 13:44 ` Thomas Huth
2021-08-11 13:58 ` Eduardo Habkost
2021-08-23 13:35 ` Markus Armbruster [this message]
2021-08-23 15:55 ` Eduardo Habkost
2021-08-24 6:48 ` Markus Armbruster
2021-09-03 9:33 ` Valeriy Vdovin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf4scmi5.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=valeriy.vdovin@virtuozzo.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox