From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K.V" Subject: Re: [PATCH] kvm: powerpc: book3s: Fix build break for BOOK3S_32 Date: Fri, 04 Oct 2013 19:54:07 +0530 Message-ID: <87li29ktbs.fsf@linux.vnet.ibm.com> References: <1380724724-12892-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <20131003041415.GA2801@iris.ozlabs.ibm.com> <36F00CBE-E313-465A-BD93-A8E1B96FD2A9@suse.de> Mime-Version: 1.0 Content-Type: text/plain Cc: benh@kernel.crashing.org, linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org To: Alexander Graf , Paul Mackerras Return-path: In-Reply-To: <36F00CBE-E313-465A-BD93-A8E1B96FD2A9@suse.de> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Alexander Graf writes: > On 04.10.2013, at 14:23, Alexander Graf wrote: > >> >> On 03.10.2013, at 06:14, Paul Mackerras wrote: >> >>> On Wed, Oct 02, 2013 at 08:08:44PM +0530, Aneesh Kumar K.V wrote: >>>> From: "Aneesh Kumar K.V" >>>> >>>> This was introduced by 85a0d845d8bb5df5d2669416212f56cbe1474c6b >>> >>> It's a good idea to give the headline of the commit as well as the ID. >>> I also like to trim the ID to 10 characters or so. So it should look >>> like this: >>> >>> This was introduced by 85a0d845d8 ("KVM: PPC: Book3S PR: Allocate >>> kvm_vcpu structs from kvm_vcpu_cache"). >>> >>>> arch/powerpc/kvm/book3s_pr.c: In function 'kvmppc_core_vcpu_create': >>>> arch/powerpc/kvm/book3s_pr.c:1182:30: error: 'struct kvmppc_vcpu_book3s' has no member named 'shadow_vcpu' >>>> make[1]: *** [arch/powerpc/kvm/book3s_pr.o] Error 1 >>>> >>>> Signed-off-by: Aneesh Kumar K.V >>> >>> Acked-by: Paul Mackerras >> >> Would you guys mind if I merge this into the offending patch? It's not trickled into -next yet, so rebasing should work. >> >> If not, please resend with the fixed commit message. > > Eh - I must've missed v2 :). So that leaves only the question on whether you'd be ok to squash the patch instead. It'd help bisectability. Yes, it should be squashed if we can do that. -aneesh