From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikunj A Dadhania Subject: Re: [RFC PATCH v1 3/5] KVM: Add paravirt kvm_flush_tlb_others Date: Wed, 02 May 2012 19:23:26 +0530 Message-ID: <87lilahep5.fsf@linux.vnet.ibm.com> References: <20120427161727.27082.43096.stgit@abhimanyu> <20120427162401.27082.59387.stgit@abhimanyu> <4F9D32B4.8040002@redhat.com> <1335865176.13683.120.camel@twins> <87obq7ge4d.fsf@linux.vnet.ibm.com> <1335954040.13683.175.camel@twins> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Avi Kivity , mingo@elte.hu, jeremy@goop.org, mtosatti@redhat.com, kvm@vger.kernel.org, x86@kernel.org, vatsa@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, hpa@zytor.com To: Peter Zijlstra Return-path: In-Reply-To: <1335954040.13683.175.camel@twins> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Wed, 02 May 2012 12:20:40 +0200, Peter Zijlstra wrote: > On Wed, 2012-05-02 at 14:21 +0530, Nikunj A Dadhania wrote: > > [root@krm1 linux]# grep HAVE_RCU_TABLE .config > > CONFIG_HAVE_RCU_TABLE_FREE=3Dy > > [root@krm1 linux]# make -j32 -s > > mm/memory.c: In function =E2=80=98tlb_remove_table_one=E2=80=99: > > mm/memory.c:315: error: implicit declaration of function =E2=80=98_= _tlb_remove_table=E2=80=99 > >=20 > > I suppose we need to have __tlb_remove_table. Trying to understand = what > > needs to be done there.=20 >=20 > Argh, I really should get back to unifying all mmu-gather > implementations :/ >=20 > I think something like the below ought to sort it. >=20 Thanks a lot. > Completely untested though.. >=20 Tested-by: Nikunj A Dadhania Here is the comparison with the other version.=20 Gang pv_spin_flush pv_spin_flush_rcu =20 1VM 1.01 0.49 0.49 =20 2VMs 7.07 4.04 4.06 =20 4VMs 9.07 5.27 5.19 =20 8VMs 9.99 7.65 7.80 =20 Will test other use cases as well and report back. Regards Nikunj