From: Cornelia Huck <cohuck@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Viktor Prutyanov <viktor@daynix.com>
Cc: jasowang@redhat.com, pasic@linux.ibm.com, farman@linux.ibm.com,
linux-s390@vger.kernel.org, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, yan@daynix.com
Subject: Re: [PATCH v4] virtio: add VIRTIO_F_NOTIFICATION_DATA feature support
Date: Wed, 22 Mar 2023 17:42:20 +0100 [thread overview]
Message-ID: <87mt44hh5f.fsf@redhat.com> (raw)
In-Reply-To: <20230322123121-mutt-send-email-mst@kernel.org>
On Wed, Mar 22 2023, "Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Wed, Mar 22, 2023 at 05:10:31PM +0300, Viktor Prutyanov wrote:
>> According to VirtIO spec v1.2, VIRTIO_F_NOTIFICATION_DATA feature
>> indicates that the driver passes extra data along with the queue
>> notifications.
>>
>> In a split queue case, the extra data is 16-bit available index. In a
>> packed queue case, the extra data is 1-bit wrap counter and 15-bit
>> available index.
>>
>> Add support for this feature for MMIO, channel I/O and modern PCI
>> transports.
>>
>> Signed-off-by: Viktor Prutyanov <viktor@daynix.com>
>> ---
>> v4: remove VP_NOTIFY macro and legacy PCI support, add
>> virtio_ccw_kvm_notify_with_data to virtio_ccw
>> v3: support feature in virtio_ccw, remove VM_NOTIFY, use avail_idx_shadow,
>> remove byte swap, rename to vring_notification_data
>> v2: reject the feature in virtio_ccw, replace __le32 with u32
>>
>> Tested with disabled VIRTIO_F_NOTIFICATION_DATA on qemu-system-s390x
>> (virtio-blk-ccw), qemu-system-riscv64 (virtio-blk-device,
>> virtio-rng-device), qemu-system-x86_64 (virtio-blk-pci, virtio-net-pci)
>> to make sure nothing is broken.
>> Tested with enabled VIRTIO_F_NOTIFICATION_DATA on 64-bit RISC-V Linux
>> and my hardware implementation of virtio-rng.
>
> what did you test? virtio pci? mmio? guessing not ccw...
>
> Cornelia could you hack up something to quickly test ccw?
Hm, I'm not entirely sure how notification data is supposed to be used
in real life -- Viktor, what is your virtio-rng implementation doing;
can this be hacked into all transports?
(Also, if the other ccw folks have something handy, please speak up :)
next prev parent reply other threads:[~2023-03-22 16:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 14:10 [PATCH v4] virtio: add VIRTIO_F_NOTIFICATION_DATA feature support Viktor Prutyanov
2023-03-22 16:33 ` Michael S. Tsirkin
2023-03-22 16:37 ` Viktor Prutyanov
2023-03-22 16:42 ` Cornelia Huck [this message]
2023-03-22 17:21 ` Viktor Prutyanov
2023-03-30 17:48 ` Eric Farman
2023-03-23 1:21 ` Xuan Zhuo
2023-03-23 7:18 ` Viktor Prutyanov
2023-03-23 7:25 ` Michael S. Tsirkin
2023-03-23 7:45 ` Xuan Zhuo
2023-03-23 7:23 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt44hh5f.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=farman@linux.ibm.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=viktor@daynix.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=yan@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).