Re: [PATCH -V2] tools/kvm/9p: Add encode/decode routines for protocol data

["Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>]

On Mon, 27 Jun 2011 10:35:49 +0300 (EEST), Pekka Enberg <penberg@kernel.org> wrote:
> This breaks 'make check':
> 
> ./kvm run -d tests/boot/boot_test.iso -p "init=init"
>    Error: unknown switch `d'
> 
>   usage: kvm run [<options>] [<kernel image>]
> 
> Basic options:
>      -0, make: *** [check] Segmentation fault
> 
> 

I am able to reproduce this on debian x86_64. A simple test as below
kvm run -sda will result in segfault. I am find the option array
corrupt. Not yet sure why the patch would make a difference. Here
is the gdb dump of the structure

====Not working dump====
(gdb) p *(opts)
$5 = {type = OPTION_GROUP, short_name = 0, long_name = 0x0, value = 0x0, argh = 0x0, help = 0x40f2b0 "Basic options:", flags = 0,
  callback = 0, defval = 38654705664}
(gdb) p *(opts+1)
$6 = {type = 99, short_name = 4256447, long_name = 0x61551800000000 <Address 0x61551800000000 out of bounds>, value = 0x0, 
  argh = 0x40f2c400000000 <Address 0x40f2c400000000 out of bounds>, help = 0x0, flags = 0, callback = 0, defval = 468151435276}
(gdb) 


==== Working dump ====
(gdb) p *(opts)
$4 = {type = OPTION_GROUP, short_name = 0, long_name = 0x0, value = 0x0, argh = 0x0, help = 0x40e9b0 "Basic options:", flags = 0,
  callback = 0, defval = 0}
(gdb) p *(opts+1)
$5 = {type = OPTION_INTEGER, short_name = 99, long_name = 0x40e9bf "cpus", value = 0x6151c8, argh = 0x0, help = 0x40e9c4 "Number of CPUs", 
  flags = 0, callback = 0, defval = 0}
(gdb)