From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [PATCH -V2] tools/kvm/9p: Add encode/decode routines for protocol data
Date: Mon, 27 Jun 2011 15:05:13 +0530
Message-ID: <87mxh3pqge.fsf@linux.vnet.ibm.com>
References: <1309154715-7555-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <alpine.DEB.2.00.1106271035320.12018@tiger>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: levinsasha928@gmail.com, kvm@vger.kernel.org
To: Pekka Enberg <penberg@kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from e33.co.us.ibm.com ([32.97.110.151]:58432 "EHLO
	e33.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755971Ab1F0Jf0 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 27 Jun 2011 05:35:26 -0400
Received: from d03relay01.boulder.ibm.com (d03relay01.boulder.ibm.com [9.17.195.226])
	by e33.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p5R9Rqnd007092
	for <kvm@vger.kernel.org>; Mon, 27 Jun 2011 03:27:52 -0600
Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168])
	by d03relay01.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p5R9ZJA6187848
	for <kvm@vger.kernel.org>; Mon, 27 Jun 2011 03:35:19 -0600
Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1])
	by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p5R3YpvA008555
	for <kvm@vger.kernel.org>; Sun, 26 Jun 2011 21:34:51 -0600
In-Reply-To: <alpine.DEB.2.00.1106271035320.12018@tiger>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, 27 Jun 2011 10:35:49 +0300 (EEST), Pekka Enberg <penberg@kernel.org> wrote:
> This breaks 'make check':
> 
> ./kvm run -d tests/boot/boot_test.iso -p "init=init"
>    Error: unknown switch `d'
> 
>   usage: kvm run [<options>] [<kernel image>]
> 
> Basic options:
>      -0, make: *** [check] Segmentation fault
> 
> 

I am able to reproduce this on debian x86_64. A simple test as below
kvm run -sda will result in segfault. I am find the option array
corrupt. Not yet sure why the patch would make a difference. Here
is the gdb dump of the structure

====Not working dump====
(gdb) p *(opts)
$5 = {type = OPTION_GROUP, short_name = 0, long_name = 0x0, value = 0x0, argh = 0x0, help = 0x40f2b0 "Basic options:", flags = 0,
  callback = 0, defval = 38654705664}
(gdb) p *(opts+1)
$6 = {type = 99, short_name = 4256447, long_name = 0x61551800000000 <Address 0x61551800000000 out of bounds>, value = 0x0, 
  argh = 0x40f2c400000000 <Address 0x40f2c400000000 out of bounds>, help = 0x0, flags = 0, callback = 0, defval = 468151435276}
(gdb) 


==== Working dump ====
(gdb) p *(opts)
$4 = {type = OPTION_GROUP, short_name = 0, long_name = 0x0, value = 0x0, argh = 0x0, help = 0x40e9b0 "Basic options:", flags = 0,
  callback = 0, defval = 0}
(gdb) p *(opts+1)
$5 = {type = OPTION_INTEGER, short_name = 99, long_name = 0x40e9bf "cpus", value = 0x6151c8, argh = 0x0, help = 0x40e9c4 "Number of CPUs", 
  flags = 0, callback = 0, defval = 0}
(gdb)