From: Cornelia Huck <cohuck@redhat.com>
To: Jason Gunthorpe <jgg@nvidia.com>,
Alex Williamson <alex.williamson@redhat.com>,
kvm@vger.kernel.org
Cc: "Christoph Hellwig" <hch@lst.de>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v4 3/5] vfio: Move vfio_spapr_iommu_eeh_ioctl into vfio_iommu_spapr_tce.c
Date: Thu, 01 Dec 2022 12:49:43 +0100 [thread overview]
Message-ID: <87o7snwdgo.fsf@redhat.com> (raw)
In-Reply-To: <3-v4-7993c351e9dc+33a818-vfio_modules_jgg@nvidia.com>
On Tue, Nov 29 2022, Jason Gunthorpe <jgg@nvidia.com> wrote:
> As with the previous patch EEH is always enabled if SPAPR_TCE_IOMMU, so
> move this last bit of code into the main module.
>
> Now that this function only processes VFIO_EEH_PE_OP remove a level of
> indenting as well, it is only called by a case statement that already
> checked VFIO_EEH_PE_OP.
>
> This eliminates an unnecessary module and SPAPR code in a global header.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
> drivers/vfio/Makefile | 1 -
> drivers/vfio/vfio_iommu_spapr_tce.c | 55 +++++++++++++++++-
> drivers/vfio/vfio_spapr_eeh.c | 88 -----------------------------
> include/linux/vfio.h | 12 ----
> 4 files changed, 53 insertions(+), 103 deletions(-)
> delete mode 100644 drivers/vfio/vfio_spapr_eeh.c
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2022-12-01 11:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 0:10 [PATCH v4 0/5] Simplify the module and kconfig structure in vfio Jason Gunthorpe
2022-11-30 0:10 ` [PATCH v4 1/5] vfio/pci: Move all the SPAPR PCI specific logic to vfio_pci_core.ko Jason Gunthorpe
2022-12-01 11:34 ` Cornelia Huck
2022-12-01 23:59 ` Alex Williamson
2022-12-02 0:40 ` Jason Gunthorpe
2022-11-30 0:10 ` [PATCH v4 2/5] vfio/spapr: Move VFIO_CHECK_EXTENSION into tce_iommu_ioctl() Jason Gunthorpe
2022-12-01 11:44 ` Cornelia Huck
2022-11-30 0:10 ` [PATCH v4 3/5] vfio: Move vfio_spapr_iommu_eeh_ioctl into vfio_iommu_spapr_tce.c Jason Gunthorpe
2022-12-01 11:49 ` Cornelia Huck [this message]
2022-11-30 0:10 ` [PATCH v4 4/5] vfio: Remove CONFIG_VFIO_SPAPR_EEH Jason Gunthorpe
2022-11-30 6:05 ` Christoph Hellwig
2022-12-01 11:54 ` Cornelia Huck
2022-11-30 0:10 ` [PATCH v4 5/5] vfio: Fold vfio_virqfd.ko into vfio.ko Jason Gunthorpe
2022-12-01 15:22 ` Cornelia Huck
2022-12-01 15:39 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7snwdgo.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=hch@lst.de \
--cc=jgg@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=philmd@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox