From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [kvm-unit-tests PATCH 3/3] arm/run: use ACCEL to choose between kvm and tcg Date: Thu, 06 Aug 2015 19:29:00 +0100 Message-ID: <87oaikjmoj.fsf@linaro.org> References: <1438624311-28713-1-git-send-email-drjones@redhat.com> <1438624311-28713-4-git-send-email-drjones@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, pbonzini@redhat.com To: Andrew Jones Return-path: Received: from mail-wi0-f177.google.com ([209.85.212.177]:35695 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753846AbbHFS3E (ORCPT ); Thu, 6 Aug 2015 14:29:04 -0400 Received: by wibxm9 with SMTP id xm9so33395767wib.0 for ; Thu, 06 Aug 2015 11:29:03 -0700 (PDT) In-reply-to: <1438624311-28713-4-git-send-email-drjones@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Andrew Jones writes: > Inspired by a patch by Alex Benn=C3=A9e. This version uses a new > unittests.cfg variable and includes support for DRYRUN. > > Signed-off-by: Andrew Jones > --- > > Another difference with Alex's patch is we no longer output > 'Running with TCG', as I don't think it's necessary. The > command line captures that, and the whole point of the patch > is to silence the '"kvm" accelerator not found.' messages > anyway. Yeah that makes sense. > > arm/run | 36 ++++++++++++++++++++++++++++++------ > arm/unittests.cfg | 4 +++- > run_tests.sh | 3 ++- > scripts/functions.bash | 8 ++++++-- > 4 files changed, 41 insertions(+), 10 deletions(-) I see your re-posting so I'll do a full review then. Is there a branch = I can re-base my stuff on top of for now? --=20 Alex Benn=C3=A9e