From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K.V" Subject: Re: [PATCH 02/23] KVM: PPC: Book3S PR: Don't corrupt guest state when kernel uses VMX Date: Thu, 08 Aug 2013 21:19:50 +0530 Message-ID: <87ob98p4gx.fsf@linux.vnet.ibm.com> References: <20130806041259.GF19254@iris.ozlabs.ibm.com> <20130806041433.GH19254@iris.ozlabs.ibm.com> Mime-Version: 1.0 Content-Type: text/plain Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org To: Paul Mackerras , Alexander Graf , Benjamin Herrenschmidt Return-path: In-Reply-To: <20130806041433.GH19254@iris.ozlabs.ibm.com> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Paul Mackerras writes: > @@ -575,8 +577,6 @@ static int kvmppc_handle_ext(struct kvm_vcpu *vcpu, unsigned int exit_nr, > printk(KERN_INFO "Loading up ext 0x%lx\n", msr); > #endif > > - current->thread.regs->msr |= msr; > - > if (msr & MSR_FP) { > for (i = 0; i < ARRAY_SIZE(vcpu->arch.fpr); i++) > thread_fpr[get_fpr_index(i)] = vcpu_fpr[i]; > @@ -598,12 +598,32 @@ static int kvmppc_handle_ext(struct kvm_vcpu *vcpu, unsigned int exit_nr, > #endif > } > > + current->thread.regs->msr |= msr; > vcpu->arch.guest_owned_ext |= msr; > kvmppc_recalc_shadow_msr(vcpu); > > return RESUME_GUEST; > } Any specific reason you are doing the above ? -aneesh