Re: [PATCH] virtio-blk: Don't free ida when disk is in use

[Rusty Russell <rusty@rustcorp.com.au>]

Alexander Graf <agraf@suse.de> writes:

> On 20.12.2012, at 09:46, Asias He <asias@redhat.com> wrote:
>
>> On 12/20/2012 12:15 PM, Rusty Russell wrote:
>>> Alexander Graf <agraf@suse.de> writes:
>>> 
>>>> When a file system is mounted on a virtio-blk disk, we then remove it
>>>> and then reattach it, the reattached disk gets the same disk name and
>>>> ids as the hot removed one.
>>>> 
>>>> This leads to very nasty effects - mostly rendering the newly attached
>>>> device completely unusable.
>>>> 
>>>> Trying what happens when I do the same thing with a USB device, I saw
>>>> that the sd node simply doesn't get free'd when a device gets forcefully
>>>> removed.
>>>> 
>>>> Imitate the same behavior for vd devices. This way broken vd devices
>>>> simply are never free'd and newly attached ones keep working just fine.
>>>> 
>>>> Signed-off-by: Alexander Graf <agraf@suse.de>
>>> 
>>> I think deserves a CC:stable, no?
>
> I wanted to make sure people can comment on it first. But yes, it should go into stable when accepted.

Queued in my fixes branch, will go to Linus soon.

Thanks,
Rusty.