Re: [RFC v2 14/17] x86/apic: Add kexec support for Secure AVIC

Thomas Gleixner
2025-03-21T15:48:13Z

On Wed, Feb 26 2025 at 14:35, Neeraj Upadhyay wrote:
>
> +/*
> + * Unregister GPA of the Secure AVIC backing page.
> + *
> + * @apic_id: APIC ID of the vCPU. Use -1ULL for the current vCPU

Yes, -1ULL is really a sensible value - NOT. Ever thought about
signed/unsigned?

> + * doing the call.

How would this function ever make sense to be invoked from a remote CPU?

> + * On success, returns previously registered GPA of the Secure AVIC
> + * backing page in gpa arg.

Please use proper kernel-doc formatting and not some made up thing which
looks like it.

Thanks,

tglx