From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Sean Christopherson <seanjc@google.com>
Cc: Anton Romanov <romanton@google.com>,
mtosatti@redhat.com, kvm@vger.kernel.org, pbonzini@redhat.com
Subject: Re: [PATCH v2] kvm: x86: Disable KVM_HC_CLOCK_PAIRING if tsc is in always catchup mode
Date: Thu, 17 Feb 2022 17:09:53 +0100 [thread overview]
Message-ID: <87pmnlpj8u.fsf@redhat.com> (raw)
In-Reply-To: <Yg5sl9aWzVJKAMKc@google.com>
Sean Christopherson <seanjc@google.com> writes:
> On Wed, Feb 16, 2022, Vitaly Kuznetsov wrote:
...
>
>> Also, EOPNOTSUPP makes it sound like the hypercall is unsupported, I'd
>> suggest changing this to KVM_EFAULT.
>
> Eh, it's consistent with the above check though, where KVM returns KVM_EOPNOTSUPP
> due to the vclock mode being incompatible. This is more or less the same, it's
> just a different "mode". KVM_EFAULT suggests that the guest did something wrong
> and/or that the guest can remedy the problem in someway, e.g. by providing a
> different address. This issue is purely in the host's domain.
Ack, Paolo's already made the change back to KVM_EOPNOTSUPP upon commit
(but I still mildly dislike using 'EOPNOTSUPP' for a temporary condition
on the host).
--
Vitaly
next prev parent reply other threads:[~2022-02-17 16:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 20:01 [PATCH v2] kvm: x86: Disable KVM_HC_CLOCK_PAIRING if tsc is in always catchup mode Anton Romanov
2022-02-16 14:14 ` Vitaly Kuznetsov
2022-02-17 15:41 ` Sean Christopherson
2022-02-17 16:09 ` Vitaly Kuznetsov [this message]
2022-02-17 17:14 ` Paolo Bonzini
2022-02-17 17:16 ` Vitaly Kuznetsov
2022-02-17 17:39 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmnlpj8u.fsf@redhat.com \
--to=vkuznets@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=romanton@google.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox