From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4FB8C433FE for ; Thu, 17 Feb 2022 16:10:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232618AbiBQQKQ (ORCPT ); Thu, 17 Feb 2022 11:10:16 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:54976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233970AbiBQQKN (ORCPT ); Thu, 17 Feb 2022 11:10:13 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4C02129C129 for ; Thu, 17 Feb 2022 08:09:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645114197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FAWt4czYDNu66iQZT9sCnbsSHD9evPpifQVxgtYTip0=; b=Vo/OjV6CgCjES8lf51jpMdA2ZoptDfd6Bkwu07BZ+KPrbPRz3EJmAhtCnQtUW0S5NQQcSM Hh3pbZkWN2UeiYbYzwpGl3vQ+KAgADrRsDT0JKZgVuyWNjW50bqK1ASPT8LBaWKSrBY1zE bwahuvbvT2jhqjbReK0GL6woNJIpbTY= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-433-kZBkAjCqOn2DD_HqH6pzTA-1; Thu, 17 Feb 2022 11:09:56 -0500 X-MC-Unique: kZBkAjCqOn2DD_HqH6pzTA-1 Received: by mail-ed1-f69.google.com with SMTP id l14-20020aa7cace000000b003f7f8e1cbbdso3789555edt.20 for ; Thu, 17 Feb 2022 08:09:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=FAWt4czYDNu66iQZT9sCnbsSHD9evPpifQVxgtYTip0=; b=xWV1mEaBep4+TzbYyMEbSOl2/0Oz1Dzd0hCKBqVaZfsUImzCXCnko+oEUeSd4TweOl Lhim+02o9/nELFcF7ixSEPLjZlnV9C5/De2iUCk+FM51kgX6bFkV/jtlp4NNAjpCsY7s 5Pvihqty0wwiNWawXghTGmg6hjbklNU0zkex/mlOyKHciz3tW0a3VZPmBsunZ6TlcDTH OhVqRBYpgnEsqjCJXN2+QsJ3n0W+F7XCoq2y5TWSxJwB6FeEryljO8c25HofWE0tRSK9 jFt9316g/Fk2X9Opd9N90lao0WIVK1pJGjuVseEPc+Ubv0HsOB2JQBdRXMvEKx7jgaM6 zMPw== X-Gm-Message-State: AOAM5303zJs7IWLSVWd/7FTCQp6sGCWyoQqgVqb98g8YbaWygwIO/m0C bnaskeJ45gXysXTRaF46f53V5j8W28QfF3Szj0NJZdo/y5YuIuaxNLeV+hPxI+k1Ok9KdFQo8z0 azhs4mLAWEh/0 X-Received: by 2002:a50:aadc:0:b0:40f:5c06:ebb7 with SMTP id r28-20020a50aadc000000b0040f5c06ebb7mr3337185edc.387.1645114194963; Thu, 17 Feb 2022 08:09:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJw7ls7ajpw46YysTgJxZNPqwUxp3yjkdCBFNPwsR1Py9bMj5lewiOH9H0LY94cCw1zKkSLKlA== X-Received: by 2002:a50:aadc:0:b0:40f:5c06:ebb7 with SMTP id r28-20020a50aadc000000b0040f5c06ebb7mr3337171edc.387.1645114194800; Thu, 17 Feb 2022 08:09:54 -0800 (PST) Received: from fedora (nat-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id d21sm1313600eja.15.2022.02.17.08.09.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Feb 2022 08:09:54 -0800 (PST) From: Vitaly Kuznetsov To: Sean Christopherson Cc: Anton Romanov , mtosatti@redhat.com, kvm@vger.kernel.org, pbonzini@redhat.com Subject: Re: [PATCH v2] kvm: x86: Disable KVM_HC_CLOCK_PAIRING if tsc is in always catchup mode In-Reply-To: References: <20220215200116.4022789-1-romanton@google.com> <87zgmqq4ox.fsf@redhat.com> Date: Thu, 17 Feb 2022 17:09:53 +0100 Message-ID: <87pmnlpj8u.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Sean Christopherson writes: > On Wed, Feb 16, 2022, Vitaly Kuznetsov wrote: ... > >> Also, EOPNOTSUPP makes it sound like the hypercall is unsupported, I'd >> suggest changing this to KVM_EFAULT. > > Eh, it's consistent with the above check though, where KVM returns KVM_EOPNOTSUPP > due to the vclock mode being incompatible. This is more or less the same, it's > just a different "mode". KVM_EFAULT suggests that the guest did something wrong > and/or that the guest can remedy the problem in someway, e.g. by providing a > different address. This issue is purely in the host's domain. Ack, Paolo's already made the change back to KVM_EOPNOTSUPP upon commit (but I still mildly dislike using 'EOPNOTSUPP' for a temporary condition on the host). -- Vitaly