From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 152DCC4332F for ; Sat, 6 Nov 2021 11:46:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E5DB9611C1 for ; Sat, 6 Nov 2021 11:46:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234072AbhKFLsl (ORCPT ); Sat, 6 Nov 2021 07:48:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:23243 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230007AbhKFLsk (ORCPT ); Sat, 6 Nov 2021 07:48:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636199159; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cnxx2Tj189dc6BUL6LWLlDG155Pqih41c6nmxkCVYvU=; b=dr9fx3yBFOkxmPfV62Leflen+5xwbDeT0MiPU/NxycPNz/5yJTQFqGSFeSqkwIW9+bM6/i b4kpwMfMNpjkCICYgk99pmb7iJdp+Ae+BFSWvQK9lT7WuPXZ5/r/Ulvy8AYH8ts+VdN0pi E6OZdSf1vs9Iid49JB+swZgjhvFjubo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-389-In9bGy23M66qZ_w69URR7g-1; Sat, 06 Nov 2021 07:45:58 -0400 X-MC-Unique: In9bGy23M66qZ_w69URR7g-1 Received: by mail-wm1-f69.google.com with SMTP id z138-20020a1c7e90000000b003319c5f9164so7289600wmc.7 for ; Sat, 06 Nov 2021 04:45:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:reply-to:date:message-id:mime-version :content-transfer-encoding; bh=Cnxx2Tj189dc6BUL6LWLlDG155Pqih41c6nmxkCVYvU=; b=45SaQPtjETF/AhAq488CRBHKcZl2VbsgpvT/ZRvgGf+2Al2t0HIKETuJxC2z9vWQaI XGh6APeSfJXySJA+hTYQ/V/wV6EQeaNahT4xZlXcZ8ATv2G/BkGy8d4gRgWqW/ZFz+fz +wHHd265N+wGfdz3vu6jicAluPPj28DO0UFkSlIBH+qInTQkhJ6kAd5DU7LCConqe+gH NdU4dOGtFZe+foXj/DkFHFZwOa85b5jGkzzQXVRVAjkaGsbFEw0kNhgHgl056+r7DX02 Tu2lbvLdtcMcIGC8Ys/jeLlv01QTTu0Wyd7Dn+JO5VUStuULsgzFMQ+fmCDriwOMWgpT uXSQ== X-Gm-Message-State: AOAM531KutGok2DWzD2W0IM0hB3lVQ/Zdr+l9+2JY3GQmvlQxz3O1IRT ZcTPoHtANAbnmqy6gYn5y9vCV6fwQAxB4TZ+XUhXH/pdoez5typY39q7nTjjT1zYzvc9wQcLiql y2dLKsifesW86 X-Received: by 2002:a7b:c4c4:: with SMTP id g4mr36521065wmk.93.1636199156727; Sat, 06 Nov 2021 04:45:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMxAvhoUUm4X8ECxWpBYCM4doPEZ8ec3FX/83U4znN+uCwNPGfmTfYrdtDKUB/9dwB/eM1YA== X-Received: by 2002:a7b:c4c4:: with SMTP id g4mr36521035wmk.93.1636199156503; Sat, 06 Nov 2021 04:45:56 -0700 (PDT) Received: from localhost ([178.139.230.94]) by smtp.gmail.com with ESMTPSA id t8sm8541831wmq.32.2021.11.06.04.45.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Nov 2021 04:45:55 -0700 (PDT) From: Juan Quintela To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Laurent Vivier , Markus Armbruster , David Hildenbrand , Eduardo Habkost , xen-devel@lists.xenproject.org, Richard Henderson , Stefano Stabellini , Marcel Apfelbaum , Eric Blake , kvm@vger.kernel.org, Peter Xu , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Paul Durrant , Paolo Bonzini , "Dr. David Alan Gilbert" , "Michael S. Tsirkin" , Anthony Perard , =?utf-8?B?SHltYW4gSHVhbmcow6nCu+KAnsOl4oC54oChKQ==?= Subject: Re: [PULL 07/20] migration/dirtyrate: implement dirty-ring dirtyrate calculation In-Reply-To: <6f8b30c5-d93d-882d-cf1a-502592e4bcf8@redhat.com> ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Thu, 4 Nov 2021 23:05:14 +0100") References: <20211101220912.10039-1-quintela@redhat.com> <20211101220912.10039-8-quintela@redhat.com> <6f8b30c5-d93d-882d-cf1a-502592e4bcf8@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Reply-To: quintela@redhat.com Date: Sat, 06 Nov 2021 12:45:54 +0100 Message-ID: <87pmrdfqx9.fsf@secure.mitica> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Philippe Mathieu-Daud=C3=A9 wrote: > Hi Juan, > > On 11/1/21 23:08, Juan Quintela wrote: >> From: Hyman Huang(=C3=A9=C2=BB=E2=80=9E=C3=A5=E2=80=B9=E2=80=A1) >>=20 >> use dirty ring feature to implement dirtyrate calculation. >>=20 >> introduce mode option in qmp calc_dirty_rate to specify what >> method should be used when calculating dirtyrate, either >> page-sampling or dirty-ring should be passed. >>=20 >> introduce "dirty_ring:-r" option in hmp calc_dirty_rate to >> indicate dirty ring method should be used for calculation. >>=20 >> Signed-off-by: Hyman Huang(=C3=A9=C2=BB=E2=80=9E=C3=A5=E2=80=B9=E2=80=A1= ) > > Just noticing in the git history some commits from your > pull request have the author name (from + S-o-b) mojibaked. Didn't knew the term. I noticed that after the fact. Still have to debug *why* my setup decided to break some of the patches and not the others. Obviosly, I have no clue about how to write/read/whatever anything that is not latin1, so if something breaks, I got in a difficult place O:-) Thanks, Juan. >> <7db445109bd18125ce8ec86816d14f6ab5de6a7d.1624040308.git.huangy81@chinat= elecom.cn> >> Reviewed-by: Peter Xu >> Reviewed-by: Juan Quintela >> Signed-off-by: Juan Quintela >> --- >> qapi/migration.json | 16 +++- >> migration/dirtyrate.c | 208 +++++++++++++++++++++++++++++++++++++++-- >> hmp-commands.hx | 7 +- >> migration/trace-events | 2 + >> 4 files changed, 218 insertions(+), 15 deletions(-)