From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Alexander Graf <graf@amazon.com>, Jim Mattson <jmattson@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
Sean Christopherson <sean.j.christopherson@intel.com>,
Wanpeng Li <wanpengli@tencent.com>,
Joerg Roedel <joro@8bytes.org>, kvm list <kvm@vger.kernel.org>,
linux-doc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Aaron Lewis <aaronlewis@google.com>
Subject: Re: [PATCH] KVM: x86: Deflect unknown MSR accesses to user space
Date: Wed, 29 Jul 2020 11:22:45 +0200 [thread overview]
Message-ID: <87pn8ellp6.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <173948e8-4c7a-6dc4-de17-99151bc56d91@amazon.com>
Alexander Graf <graf@amazon.com> writes:
> On 29.07.20 10:23, Vitaly Kuznetsov wrote:
>>
>>
>>
>> Jim Mattson <jmattson@google.com> writes:
>>
>>> On Tue, Jul 28, 2020 at 5:41 AM Alexander Graf <graf@amazon.com> wrote:
>>>>
>>
>> ...
>>
>>>> While it does feel a bit overengineered, it would solve the problem that
>>>> we're turning in-KVM handled MSRs into an ABI.
>>>
>>> It seems unlikely that userspace is going to know what to do with a
>>> large number of MSRs. I suspect that a small enumerated list will
>>> suffice.
>>
>> The list can also be 'wildcarded', i.e.
>> {
>> u32 index;
>> u32 mask;
>> ...
>> }
>>
>> to make it really short.
>
> I like the idea of wildcards, but I can't quite wrap my head around how
> we would implement ignore_msrs in user space with them?
>
For that I think we can still deflect all unknown MSR accesses to
userspace (when the CAP is enabled of course ) but MSRs which are on the
list will *have to be deflected*, i.e. KVM can't handle them internally
without consulting with userspace.
We can make it tunable through a parameter for CAP enablement if needed.
--
Vitaly
next prev parent reply other threads:[~2020-07-29 9:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 0:44 [PATCH] KVM: x86: Deflect unknown MSR accesses to user space Alexander Graf
2020-07-28 8:15 ` Vitaly Kuznetsov
2020-07-28 12:41 ` Alexander Graf
2020-07-28 17:13 ` Jim Mattson
2020-07-29 8:23 ` Vitaly Kuznetsov
2020-07-29 9:09 ` Alexander Graf
2020-07-29 9:22 ` Vitaly Kuznetsov [this message]
2020-07-29 9:34 ` Alexander Graf
2020-07-29 9:06 ` Alexander Graf
2020-07-29 18:27 ` Jim Mattson
2020-07-29 20:28 ` Alexander Graf
2020-07-29 20:37 ` Jim Mattson
2020-07-29 20:45 ` Alexander Graf
2020-07-29 20:49 ` Jim Mattson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pn8ellp6.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=aaronlewis@google.com \
--cc=corbet@lwn.net \
--cc=graf@amazon.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox