From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH v6 00/12] KVM Guest Debug support for arm64 Date: Thu, 25 Jun 2015 07:33:46 +0100 Message-ID: <87pp4kxpo5.fsf@linaro.org> References: <1434716630-18260-1-git-send-email-alex.bennee@linaro.org> <20150624201915.GC22785@cbox> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com, peter.maydell@linaro.org, agraf@suse.de, drjones@redhat.com, pbonzini@redhat.com, zhichao.huang@linaro.org, jan.kiszka@siemens.com, dahi@linux.vnet.ibm.com, r65777@freescale.com, bp@suse.de To: Christoffer Dall Return-path: Received: from mail-wg0-f42.google.com ([74.125.82.42]:36425 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751715AbbFYGdI (ORCPT ); Thu, 25 Jun 2015 02:33:08 -0400 Received: by wguu7 with SMTP id u7so53596654wgu.3 for ; Wed, 24 Jun 2015 23:33:07 -0700 (PDT) In-reply-to: <20150624201915.GC22785@cbox> Sender: kvm-owner@vger.kernel.org List-ID: Christoffer Dall writes: > On Fri, Jun 19, 2015 at 01:23:38PM +0100, Alex Benn=C3=A9e wrote: >> Here is V6 of the KVM Guest Debug support for arm64. >>=20 >> The changes are even more minimal than the last round which is >> hopefully a good indication the series is ready for merging: >>=20 > Unfortunately this series breaks the build on 32-bit ARM: I'll get on those today. > > > /home/christoffer/src/kvmarm/arm64/linux-kvm-arm/arch/arm/kvm/arm.c: = In function =E2=80=98kvm_arch_vcpu_init=E2=80=99: > /home/christoffer/src/kvmarm/arm64/linux-kvm-arm/arch/arm/kvm/arm.c:2= 83:12: error: =E2=80=98struct kvm_vcpu_arch=E2=80=99 has no member name= d =E2=80=98debug_ptr=E2=80=99 > vcpu->arch.debug_ptr =3D &vcpu->arch.vcpu_debug_state; > ^ > /home/christoffer/src/kvmarm/arm64/linux-kvm-arm/arch/arm/kvm/arm.c:2= 83:36: error: =E2=80=98struct kvm_vcpu_arch=E2=80=99 has no member name= d =E2=80=98vcpu_debug_state=E2=80=99 > vcpu->arch.debug_ptr =3D &vcpu->arch.vcpu_debug_state; > ^ > /home/christoffer/src/kvmarm/arm64/linux-kvm-arm/arch/arm/kvm/arm.c: = In function =E2=80=98kvm_arch_vcpu_ioctl_set_guest_debug=E2=80=99: > /home/christoffer/src/kvmarm/arm64/linux-kvm-arm/arch/arm/kvm/arm.c:3= 09:8: error: =E2=80=98KVM_GUESTDBG_USE_SW_BP=E2=80=99 undeclared (first= use in this function) > KVM_GUESTDBG_USE_SW_BP | \ > ^ > /home/christoffer/src/kvmarm/arm64/linux-kvm-arm/arch/arm/kvm/arm.c:3= 28:22: note: in expansion of macro =E2=80=98KVM_GUESTDBG_VALID_MASK=E2=80= =99 > if (dbg->control & ~KVM_GUESTDBG_VALID_MASK) > ^ > /home/christoffer/src/kvmarm/arm64/linux-kvm-arm/arch/arm/kvm/arm.c:3= 09:8: note: each undeclared identifier is reported only once for each f= unction it appears in > KVM_GUESTDBG_USE_SW_BP | \ > ^ > /home/christoffer/src/kvmarm/arm64/linux-kvm-arm/arch/arm/kvm/arm.c:3= 28:22: note: in expansion of macro =E2=80=98KVM_GUESTDBG_VALID_MASK=E2=80= =99 > if (dbg->control & ~KVM_GUESTDBG_VALID_MASK) > ^ > /home/christoffer/src/kvmarm/arm64/linux-kvm-arm/arch/arm/kvm/arm.c:3= 10:8: error: =E2=80=98KVM_GUESTDBG_USE_HW=E2=80=99 undeclared (first us= e in this function) > KVM_GUESTDBG_USE_HW | \ > ^ > /home/christoffer/src/kvmarm/arm64/linux-kvm-arm/arch/arm/kvm/arm.c:3= 28:22: note: in expansion of macro =E2=80=98KVM_GUESTDBG_VALID_MASK=E2=80= =99 > if (dbg->control & ~KVM_GUESTDBG_VALID_MASK) > ^ > /home/christoffer/src/kvmarm/arm64/linux-kvm-arm/arch/arm/kvm/arm.c:3= 36:14: error: =E2=80=98struct kvm_vcpu_arch=E2=80=99 has no member name= d =E2=80=98external_debug_state=E2=80=99 > vcpu->arch.external_debug_state =3D dbg->arch; > ^ > make[2]: *** [arch/arm/kvm/arm.o] Error 1 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [arch/arm/kvm] Error 2 > make[1]: *** Waiting for unfinished jobs.... > make: *** [sub-make] Error 2 > > > -Christoffer --=20 Alex Benn=C3=A9e