From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K.V" Subject: Re: [PATCH qemu-kvm] virtfs-proxy: fix build with F18 Date: Thu, 28 Feb 2013 14:28:54 +0530 Message-ID: <87ppzk4xwx.fsf@linux.vnet.ibm.com> References: <20130228070047.GA22780@redhat.com> Mime-Version: 1.0 Content-Type: text/plain To: "Michael S. Tsirkin" , kvm@vger.kernel.org, gleb@redhat.com Return-path: Received: from e23smtp06.au.ibm.com ([202.81.31.148]:46454 "EHLO e23smtp06.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750886Ab3B1I7D (ORCPT ); Thu, 28 Feb 2013 03:59:03 -0500 Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 28 Feb 2013 18:54:14 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 58631357802D for ; Thu, 28 Feb 2013 19:58:58 +1100 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r1S8kJYw7733656 for ; Thu, 28 Feb 2013 19:46:20 +1100 Received: from d23av01.au.ibm.com (loopback [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r1S8wuJ8026013 for ; Thu, 28 Feb 2013 19:58:57 +1100 In-Reply-To: <20130228070047.GA22780@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: "Michael S. Tsirkin" writes: > Ignoring return value of setfsgid(gid) and setfsuid(uid) causes > warnings on F18. Check the return value: man page says > glibc returns -1 on error. > > Signed-off-by: Michael S. Tsirkin > --- > fsdev/virtfs-proxy-helper.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c > index f9a8270..2f0d2b3 100644 > --- a/fsdev/virtfs-proxy-helper.c > +++ b/fsdev/virtfs-proxy-helper.c > @@ -282,6 +282,7 @@ static int send_status(int sockfd, struct iovec *iovec, int status) > */ > static int setfsugid(int uid, int gid) > { > + int ret; > /* > * We still need DAC_OVERRIDE because we don't change > * supplementary group ids, and hence may be subjected DAC rules > @@ -290,8 +291,10 @@ static int setfsugid(int uid, int gid) > CAP_DAC_OVERRIDE, > }; > > - setfsgid(gid); > - setfsuid(uid); > + ret = setfsgid(gid); > + assert(ret != -1); > + ret = setfsuid(uid); > + assert(ret != -1); > > if (uid != 0 || gid != 0) { > return do_cap_set(cap_list, ARRAY_SIZE(cap_list), 0); > -- > MST This got fixed upstream. http://git.qemu.org/?p=qemu.git;a=commitdiff;h=9fd2ecdc8cb2dc1a8a7c57b6c9c60bc9947b6a73 -aneesh