From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21B8F1D696 for ; Mon, 22 Jul 2024 13:38:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721655495; cv=none; b=ajl7vs8J8R206QFDGVqR7m2MYbrbYd8FxwvdIZpHySsLbPSsq+NUhqHPQUeuKOrbBQDZs98uq0HELoY9dovbd/Mhy3spE5husgxqY8+W8S017PoQeZow0lpnmIbYuG9xtMhwpQYL38fcbWzWqBqdWEEPzW5SHGZf6gvq0GXQyx0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721655495; c=relaxed/simple; bh=Q2A4hgSQ72LrxyROvWQyeoldy5+bPyMK3I5rPE2mhzc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=C1DXDhTaMbmatxNf34tfVhWmQO7pPhya1o5/vDLUNpjKJiv6k1+rnD8DsS07Du/pOwtrIHQ3pX/0w+ZEExYdBKiLn/ATq9A1NSwAqFqWOSXTboX1doAAVUM235gy+7b3JplHgGIxsH5ugYRCKoAuEmNoUkb22MGXebwjh8tYDx0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bMk9Um/S; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bMk9Um/S" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721655492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9EiBCLqkK09Y1BVxrLWcGqAzYTQfgigTA0WYXbrnHsM=; b=bMk9Um/S4ylAO6LhuVaEaSRWbYkIsTH9ozr1l8qZelJ3uxPHZnWmBXwq4f5Np4Y4idxoRN mzgbVljuB3DZyIPHR1vYqQ1qWTAseTuPnRVG2NZoRgmS7O9zcWLMPQ2fQ2eyHjGth2H51w xvHg5V0MDwrbPCyUJZjDWkO6ff0hPqI= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-217-YUk80kGdPXGEVKtTCjXqAQ-1; Mon, 22 Jul 2024 09:38:06 -0400 X-MC-Unique: YUk80kGdPXGEVKtTCjXqAQ-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5BF23196E0A0; Mon, 22 Jul 2024 13:37:55 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.65]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D52391944AA4; Mon, 22 Jul 2024 13:37:45 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id AB0FB21E669B; Mon, 22 Jul 2024 15:37:43 +0200 (CEST) From: Markus Armbruster To: Zhao Liu Cc: Daniel P . =?utf-8?Q?Berrang=C3=A9?= , Eduardo Habkost , Marcel Apfelbaum , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Yanan Wang , "Michael S . Tsirkin" , Paolo Bonzini , Richard Henderson , Eric Blake , Marcelo Tosatti , Alex =?utf-8?Q?Benn=C3=A9e?= , Peter Maydell , Jonathan Cameron , Sia Jee Heng , qemu-devel@nongnu.org, kvm@vger.kernel.org, qemu-riscv@nongnu.org, qemu-arm@nongnu.org, Zhenyu Wang , Dapeng Mi , Yongwei Ma Subject: Re: [PATCH 8/8] qemu-options: Add the description of smp-cache object In-Reply-To: <20240704031603.1744546-9-zhao1.liu@intel.com> (Zhao Liu's message of "Thu, 4 Jul 2024 11:16:03 +0800") References: <20240704031603.1744546-1-zhao1.liu@intel.com> <20240704031603.1744546-9-zhao1.liu@intel.com> Date: Mon, 22 Jul 2024 15:37:43 +0200 Message-ID: <87r0bl35ug.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 Zhao Liu writes: > Signed-off-by: Zhao Liu This patch is just documentation. The code got added in some previous patch. Would it make sense to squash this patch into that previous patch? > --- > Changes since RFC v2: > * Rewrote the document of smp-cache object. > > Changes since RFC v1: > * Use "*_cache=topo_level" as -smp example as the original "level" > term for a cache has a totally different meaning. (Jonathan) > --- > qemu-options.hx | 58 +++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 58 insertions(+) > > diff --git a/qemu-options.hx b/qemu-options.hx > index 8ca7f34ef0c8..4b84f4508a6e 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -159,6 +159,15 @@ SRST > :: > > -machine cxl-fmw.0.targets.0=cxl.0,cxl-fmw.0.targets.1=cxl.1,cxl-fmw.0.size=128G,cxl-fmw.0.interleave-granularity=512 > + > + ``smp-cache='id'`` > + Allows to configure cache property (now only the cache topology level). > + > + For example: > + :: > + > + -object '{"qom-type":"smp-cache","id":"cache","caches":[{"name":"l1d","topo":"core"},{"name":"l1i","topo":"core"},{"name":"l2","topo":"module"},{"name":"l3","topo":"die"}]}' > + -machine smp-cache=cache > ERST > > DEF("M", HAS_ARG, QEMU_OPTION_M, > @@ -5871,6 +5880,55 @@ SRST > :: > > (qemu) qom-set /objects/iothread1 poll-max-ns 100000 > + > + ``-object '{"qom-type":"smp-cache","id":id,"caches":[{"name":cache_name,"topo":cache_topo}]}'`` > + Create an smp-cache object that configures machine's cache > + property. Currently, cache property only include cache topology > + level. > + > + This option must be written in JSON format to support JSON list. Why? > + > + The ``caches`` parameter accepts a list of cache property in JSON > + format. > + > + A list element requires the cache name to be specified in the > + ``name`` parameter (currently ``l1d``, ``l1i``, ``l2`` and ``l3`` > + are supported). ``topo`` parameter accepts CPU topology levels > + including ``thread``, ``core``, ``module``, ``cluster``, ``die``, > + ``socket``, ``book``, ``drawer`` and ``default``. The ``topo`` > + parameter indicates CPUs winthin the same CPU topology container > + are sharing the same cache. > + > + Some machines may have their own cache topology model, and this > + object may override the machine-specific cache topology setting > + by specifying smp-cache object in the -machine. When specifying > + the cache topology level of ``default``, it will honor the default > + machine-specific cache topology setting. For other topology levels, > + they will override the default setting. > + > + An example list of caches to configure the cache model (l1d cache > + per core, l1i cache per core, l2 cache per module and l3 cache per > + socket) supported by PC machine might look like: > + > + :: > + > + { > + "caches": [ > + { "name": "l1d", "topo": "core" }, > + { "name": "l1i", "topo": "core" }, > + { "name": "l2", "topo": "module" }, > + { "name": "l3", "topo": "socket" }, > + ] > + } > + > + An example smp-cache object would look like:() > + > + .. parsed-literal:: > + > + # |qemu_system| \\ > + ... \\ > + -object '{"qom-type":"smp-cache","id":id,"caches":[{"name":cache_name,"topo":cache_topo}]}' \\ > + ... > ERST