RE: [PATCH 15/19] kvm: x86: Save and restore guest XFD_ERR properly

Tian, Kevin
2021-12-11T03:23:29Z

> From: Paolo Bonzini
> Sent: Saturday, December 11, 2021 9:32 AM
>
> On 12/11/21 01:10, Thomas Gleixner wrote:
> > 2) When the guest triggers #NM is takes an VMEXIT and the host
> > does:
> >
> > rdmsrl(MSR_XFD_ERR, vcpu->arch.guest_fpu.xfd_err);
> >
> > injects the #NM and goes on.
> >
> > 3) When the guest writes to MSR_XFD_ERR it takes an VMEXIT and
> > the host does:
> >
> > vcpu->arch.guest_fpu.xfd_err = msrval;
> > wrmsrl(MSR_XFD_ERR, msrval);
>
> No wrmsrl here I think, the host value is 0 and should stay so. Instead
> the wrmsrl will happen the next time the VCPU loop is entred.
>

To elaborate I guess the reason is because MSR_XFD_ERR should
always contain host value 0 after preemption is enabled, while
WRMSR emulation is called with preemption enabled. Then we
just need wait for the next time the vcpu loop is entered to
restore the guest value after preemption is disabled. 😊

Thanks
Kevin