From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40CE14B95CF for ; Mon, 28 Sep 2026 12:03:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790597010; cv=none; b=kTT4CK5su2HMr0/wcb0IURjAufrk9ySTdV+uqW4OgeR/S5J08Rh3cBiJYeo7Y8qJtY7StOEB+LNRg146pHo98ubBON7uPZJaWMmeLYN1RnWn3dupyg8+i6TsCSo9lKIBrDYLhTIoICj+4ylwdkXRnsX1yHajaGfLQUcZAIZ72V0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790597010; c=relaxed/simple; bh=lHrb1frmLltwlGoGBJJnj2k3T7FRDNfMWu6hu7gliHI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=uzFsvKW8m/199F6vGWjlkpVYMKnvERN19nqsbdep5g3nIQYc3yT04b6UGaVLr43QyPmz/TRxPCr8qbH2aciAcikcm+fWYQ+oKsdWvYQutUDIBASOFYOnVLaoZbA6duFMUjDfbgRvBtHdFc/9HWs4h7EQsVji4u9kM6lSBBPQBvk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bw9SP+Zd; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bw9SP+Zd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790597008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=198HLUE7nj8MuKtdpZw6KT9sUJQ17m+O7A96pp/kfMo=; b=bw9SP+ZdGWtPz/pOHkn2pFgSyOIVTHKcGFiek1LbmPUooww4zqKuAZ4pImRoqFmPMoWYF4 +VDUL7z0zKgaVyPxj2Xnc/F9G7HsijNOiWAQEhD1+MPfd8xR+1wq/Rm8R/hrdum231Xa6c RH5prmaWP/7quIpsELyjSb1zLdopB94= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-208-Igh5X9UDNmy09h7qq2N4bg-1; Mon, 28 Sep 2026 08:03:24 -0400 X-MC-Unique: Igh5X9UDNmy09h7qq2N4bg-1 X-Mimecast-MFC-AGG-ID: Igh5X9UDNmy09h7qq2N4bg_1790597002 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2C1D619539BD; Mon, 28 Sep 2026 12:03:22 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.44.22.5]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6A62A1956087; Mon, 28 Sep 2026 12:03:21 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 0B4B921E6A04; Mon, 28 Sep 2026 14:03:19 +0200 (CEST) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Cc: Yonggang Luo , qemu-devel@nongnu.org, Richard Henderson , Philippe =?utf-8?Q?Mathieu-Dau?= =?utf-8?Q?d=C3=A9?= , "Edgar E. Iglesias" , Pierrick Bouvier , Fabiano Rosas , Laurent Vivier , Paolo Bonzini , Alistair Francis , Peter Maydell , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , qemu-arm@nongnu.org, kvm@vger.kernel.org Subject: Re: [PATCH v4 46/55] qapi: add query-targets In-Reply-To: ("Daniel P. =?utf-8?Q?Berrang?= =?utf-8?Q?=C3=A9=22's?= message of "Mon, 28 Sep 2026 11:13:48 +0100") References: <20260926070057.1234-1-luoyonggang@gmail.com> <20260926070057.1234-47-luoyonggang@gmail.com> Date: Mon, 28 Sep 2026 14:03:19 +0200 Message-ID: <87se2tfurc.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Daniel P. Berrang=C3=A9 writes: > On Sat, Sep 26, 2026 at 03:00:45PM +0800, Yonggang Luo wrote: >> query-targets lists each linked target, including none, with its >> arch, endianness, and the machines that target accepts. >>=20 >> Signed-off-by: Yonggang Luo >> --- >> hw/core/machine-qmp-cmds.c | 30 ++++++++++++++++++++++++++++++ >> qapi/machine.json | 35 +++++++++++++++++++++++++++++++++++ >> 2 files changed, 65 insertions(+) > > >> diff --git a/qapi/machine.json b/qapi/machine.json >> index 6aaa2af709a..d8cdea6203e 100644 >> --- a/qapi/machine.json >> +++ b/qapi/machine.json >> @@ -307,6 +307,41 @@ >> ## >> { 'command': 'query-target', 'returns': 'QemuTargetInfo' } >>=20=20 >> +## >> +# @TargetMachines: >> +# >> +# One registered system target and the machines that can run on it. >> +# >> +# @arch: the target architecture >> +# >> +# @endianness: the target endianness >> +# >> +# @machines: machine type names, not aliases >> +# >> +# Since: 11.2 >> +## >> +{ 'struct': 'TargetMachines', >> + 'data': { 'arch': 'SysEmuTarget', >> + 'endianness': 'EndianMode', >> + 'machines': ['str'] } } > > We already have 'QemuTargetInfo' struct which is used > with 'query-target', that should also be used with the > new 'query-targets' command. > > We need to add the 'endianness' field to QemuTargetInfo. > > I don't think that we need to report machines though. > We already have 'query-machines' which gives much broader > information on the machines. "MachineInfo" needs to > gain > > "targets": ["SysEmuTarget"] > > to list which target(s) a machine can be used with. Do we need query-targets at all? What information does it provide that cannot easily be computed from query-machines once we add @target and @endiannes to MachineInfo? >> + >> +## >> +# @query-targets: >> +# >> +# Return each target linked into this QEMU binary and the machines >> +# whose availability check accepts that target. >> +# >> +# Since: 11.2 >> +# >> +# .. qmp-example:: >> +# >> +# -> { "execute": "query-targets" } >> +# <- { "return": [ { "arch": "aarch64", "endianness": "little", >> +# "machines": [ "virt" ] } ] } >> +## >> +{ 'command': 'query-targets', >> + 'returns': ['TargetMachines'] } > > > With regards, > Daniel