Re: [PATCH v3 27/70] i386/tdx: Add property sept-ve-disable for tdx-guest object

Markus Armbruster
2023-12-01T10:53:36Z

Xiaoyao Li <xiaoyao.li@intel.com> writes:

> Bit 28 of TD attribute, named SEPT_VE_DISABLE. When set to 1, it disables
> EPT violation conversion to #VE on guest TD access of PENDING pages.
>
> Some guest OS (e.g., Linux TD guest) may require this bit as 1.
> Otherwise refuse to boot.
>
> Add sept-ve-disable property for tdx-guest object, for user to configure
> this bit.
>
> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
> Acked-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> Changes in v3:
> - update the comment of property @sept-ve-disable to make it more
> descriptive and use new format. (Daniel and Markus)
> ---
> qapi/qom.json | 7 ++++++-
> target/i386/kvm/tdx.c | 24 ++++++++++++++++++++++++
> 2 files changed, 30 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/qom.json b/qapi/qom.json
> index 8e08257dac2f..3a29659e0155 100644
> --- a/qapi/qom.json
> +++ b/qapi/qom.json
> @@ -883,10 +883,15 @@
> #
> # Properties for tdx-guest objects.
> #
> +# @sept-ve-disable: toggle bit 28 of TD attributes to control disabling
> +# of EPT violation conversion to #VE on guest TD access of PENDING
> +# pages. Some guest OS (e.g., Linux TD guest) may require this to
> +# be set, otherwise they refuse to boot.
> +#
> # Since: 8.2
> ##
> { 'struct': 'TdxGuestProperties',
> - 'data': { }}
> + 'data': { '*sept-ve-disable': 'bool' } }
>
> ##
> # @ThreadContextProperties:

Acked-by: Markus Armbruster <armbru@redhat.com> …