From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A54C1CCA473 for ; Tue, 21 Jun 2022 10:00:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231127AbiFUJ75 (ORCPT ); Tue, 21 Jun 2022 05:59:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349238AbiFUJ62 (ORCPT ); Tue, 21 Jun 2022 05:58:28 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A416326AF5 for ; Tue, 21 Jun 2022 02:58:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655805505; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=H4C/sB5um4hN9/XHAJjRJCQS2mg0bGELmgXp1B2D5DI=; b=gk4t6USREeSuC5RQ7vIMs15xiTmEmZWvRlryiiUzAxmEnkREWAPZ4aQLLwYVTIH/kSJA/U LQyEYe7Um3KqemrRsNXvn/itTjZQBJCTs9jq5ISn8Lhlu7OZCcibYZJ3Py5l80Mx1rrhpp jxiEqJSBYAxGopmKGFde+FjWlJG5d4c= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-613-88tBitKPN0CK2RYLsijSLA-1; Tue, 21 Jun 2022 05:58:21 -0400 X-MC-Unique: 88tBitKPN0CK2RYLsijSLA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F208F101E9BC; Tue, 21 Jun 2022 09:58:20 +0000 (UTC) Received: from localhost (unknown [10.39.193.229]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9F16F1121314; Tue, 21 Jun 2022 09:58:20 +0000 (UTC) From: Cornelia Huck To: Jason Wang Cc: Halil Pasic , mst , Vasily Gorbik , Christian Borntraeger , Alexander Gordeev , linux-s390@vger.kernel.org, virtualization , kvm , linux-kernel Subject: Re: [PATCH V2] virtio: disable notification hardening by default In-Reply-To: Organization: Red Hat GmbH References: <20220620024158.2505-1-jasowang@redhat.com> <87y1xq8jgw.fsf@redhat.com> User-Agent: Notmuch/0.36 (https://notmuchmail.org) Date: Tue, 21 Jun 2022 11:58:19 +0200 Message-ID: <87sfny8hj8.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Jun 21 2022, Jason Wang wrote: > On Tue, Jun 21, 2022 at 5:16 PM Cornelia Huck wrote: >> >> The ifdeffery looks a big ugly, but I don't have a better idea. > > I guess you meant the ccw part, I leave the spinlock here in V1, but > Michael prefers to have that. Not doing the locking dance is good; I think the #ifdefs all over are a bit ugly, but as I said, I can't think of a good, less-ugly way... > In the future, we may consider removing that, one possible way is to > have a per driver boolean for the hardening. As in "we've reviewed and tested this driver, so let's turn it on for every device bound to it"?