From: Cornelia Huck <cohuck@redhat.com>
To: Heiko Carstens <hca@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Janosch Frank <frankja@linux.vnet.ibm.com>
Cc: David Hildenbrand <david@redhat.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH] KVM: s390: get rid of register asm usage
Date: Mon, 21 Jun 2021 16:34:26 +0200 [thread overview]
Message-ID: <87sg1bnv65.fsf@redhat.com> (raw)
In-Reply-To: <20210621140356.1210771-1-hca@linux.ibm.com>
%On Mon, Jun 21 2021, Heiko Carstens <hca@linux.ibm.com> wrote:
> Using register asm statements has been proven to be very error prone,
> especially when using code instrumentation where gcc may add function
> calls, which clobbers register contents in an unexpected way.
>
> Therefore get rid of register asm statements in kvm code, even though
> there is currently nothing wrong with them. This way we know for sure
> that this bug class won't be introduced here.
>
> Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
> ---
> arch/s390/kvm/kvm-s390.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2021-06-21 14:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 14:03 [PATCH] KVM: s390: get rid of register asm usage Heiko Carstens
2021-06-21 14:34 ` Cornelia Huck [this message]
2021-06-21 14:39 ` Claudio Imbrenda
2021-06-22 7:36 ` Thomas Huth
2021-06-22 7:43 ` Christian Borntraeger
2021-06-22 7:46 ` Thomas Huth
2021-06-22 7:50 ` Christian Borntraeger
2021-06-22 7:53 ` Thomas Huth
2021-06-22 7:57 ` Christian Borntraeger
2021-06-22 8:00 ` Christian Borntraeger
2021-06-22 8:04 ` Thomas Huth
2021-06-22 14:56 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg1bnv65.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.vnet.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox