* [PATCH 1/1] KVM: x86: remove unused declaration of kvm_write_tsc()
@ 2021-03-26 7:03 Dongli Zhang
2021-03-26 9:45 ` Vitaly Kuznetsov
2021-03-26 17:14 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Dongli Zhang @ 2021-03-26 7:03 UTC (permalink / raw)
To: kvm, x86
Cc: pbonzini, seanjc, vkuznets, wanpengli, jmattson, joro, tglx,
mingo, bp, hpa, linux-kernel
The kvm_write_tsc() was not used since commit 0c899c25d754 ("KVM: x86: do
not attempt TSC synchronization on guest writes"). Remove its unused
declaration.
Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
---
arch/x86/kvm/x86.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/kvm/x86.h b/arch/x86/kvm/x86.h
index 39eb04887141..9035e34aa156 100644
--- a/arch/x86/kvm/x86.h
+++ b/arch/x86/kvm/x86.h
@@ -250,7 +250,6 @@ static inline bool kvm_vcpu_latch_init(struct kvm_vcpu *vcpu)
void kvm_write_wall_clock(struct kvm *kvm, gpa_t wall_clock, int sec_hi_ofs);
void kvm_inject_realmode_interrupt(struct kvm_vcpu *vcpu, int irq, int inc_eip);
-void kvm_write_tsc(struct kvm_vcpu *vcpu, struct msr_data *msr);
u64 get_kvmclock_ns(struct kvm *kvm);
int kvm_read_guest_virt(struct kvm_vcpu *vcpu,
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] KVM: x86: remove unused declaration of kvm_write_tsc()
2021-03-26 7:03 [PATCH 1/1] KVM: x86: remove unused declaration of kvm_write_tsc() Dongli Zhang
@ 2021-03-26 9:45 ` Vitaly Kuznetsov
2021-03-26 17:14 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Vitaly Kuznetsov @ 2021-03-26 9:45 UTC (permalink / raw)
To: Dongli Zhang, kvm, x86
Cc: pbonzini, seanjc, wanpengli, jmattson, joro, tglx, mingo, bp, hpa,
linux-kernel
Dongli Zhang <dongli.zhang@oracle.com> writes:
> The kvm_write_tsc() was not used since commit 0c899c25d754 ("KVM: x86: do
> not attempt TSC synchronization on guest writes"). Remove its unused
> declaration.
It's not just not used, it's not present. Let me try to rephrase the
commit message a bit:
"
Commit 0c899c25d754 ("KVM: x86: do not attempt TSC synchronization on
guest writes") renamed kvm_write_tsc() to kvm_synchronize_tsc() and made
it 'static'. Remove the leftover declaration from x86.h
Fixes: 0c899c25d754 ("KVM: x86: do not attempt TSC synchronization on
guest writes")
"
The subject line should probably also get adjusted like
"KVM: x86: remove dangling declaration of kvm_write_tsc()"
>
> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
> ---
> arch/x86/kvm/x86.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kvm/x86.h b/arch/x86/kvm/x86.h
> index 39eb04887141..9035e34aa156 100644
> --- a/arch/x86/kvm/x86.h
> +++ b/arch/x86/kvm/x86.h
> @@ -250,7 +250,6 @@ static inline bool kvm_vcpu_latch_init(struct kvm_vcpu *vcpu)
> void kvm_write_wall_clock(struct kvm *kvm, gpa_t wall_clock, int sec_hi_ofs);
> void kvm_inject_realmode_interrupt(struct kvm_vcpu *vcpu, int irq, int inc_eip);
>
> -void kvm_write_tsc(struct kvm_vcpu *vcpu, struct msr_data *msr);
> u64 get_kvmclock_ns(struct kvm *kvm);
>
> int kvm_read_guest_virt(struct kvm_vcpu *vcpu,
--
Vitaly
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] KVM: x86: remove unused declaration of kvm_write_tsc()
2021-03-26 7:03 [PATCH 1/1] KVM: x86: remove unused declaration of kvm_write_tsc() Dongli Zhang
2021-03-26 9:45 ` Vitaly Kuznetsov
@ 2021-03-26 17:14 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2021-03-26 17:14 UTC (permalink / raw)
To: Dongli Zhang, kvm, x86
Cc: seanjc, vkuznets, wanpengli, jmattson, joro, tglx, mingo, bp, hpa,
linux-kernel
On 26/03/21 08:03, Dongli Zhang wrote:
> The kvm_write_tsc() was not used since commit 0c899c25d754 ("KVM: x86: do
> not attempt TSC synchronization on guest writes"). Remove its unused
> declaration.
>
> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
> ---
> arch/x86/kvm/x86.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kvm/x86.h b/arch/x86/kvm/x86.h
> index 39eb04887141..9035e34aa156 100644
> --- a/arch/x86/kvm/x86.h
> +++ b/arch/x86/kvm/x86.h
> @@ -250,7 +250,6 @@ static inline bool kvm_vcpu_latch_init(struct kvm_vcpu *vcpu)
> void kvm_write_wall_clock(struct kvm *kvm, gpa_t wall_clock, int sec_hi_ofs);
> void kvm_inject_realmode_interrupt(struct kvm_vcpu *vcpu, int irq, int inc_eip);
>
> -void kvm_write_tsc(struct kvm_vcpu *vcpu, struct msr_data *msr);
> u64 get_kvmclock_ns(struct kvm *kvm);
>
> int kvm_read_guest_virt(struct kvm_vcpu *vcpu,
>
Queued, thanks (with slight editing of the commit message as Vitaly
mentioned).
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-26 17:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-26 7:03 [PATCH 1/1] KVM: x86: remove unused declaration of kvm_write_tsc() Dongli Zhang
2021-03-26 9:45 ` Vitaly Kuznetsov
2021-03-26 17:14 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox