From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [PATCH 1/2] tools/kvm/9p: Always include system header before our headers
Date: Sat, 18 Jun 2011 12:37:42 +0530
Message-ID: <87sjr71utd.fsf@linux.vnet.ibm.com>
References: <1308334282-11865-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1308339906.8711.13.camel@lappy> <1308340059.28516.3.camel@jaguar>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org
To: Pekka Enberg <penberg@kernel.org>,
	Sasha Levin <levinsasha928@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from e35.co.us.ibm.com ([32.97.110.153]:43383 "EHLO
	e35.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751756Ab1FRHHy (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sat, 18 Jun 2011 03:07:54 -0400
Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227])
	by e35.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p5I6nqpx010567
	for <kvm@vger.kernel.org>; Sat, 18 Jun 2011 00:49:52 -0600
Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170])
	by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id p5I77ohH137316
	for <kvm@vger.kernel.org>; Sat, 18 Jun 2011 01:07:50 -0600
Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1])
	by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p5I17nNn022149
	for <kvm@vger.kernel.org>; Fri, 17 Jun 2011 19:07:49 -0600
In-Reply-To: <1308340059.28516.3.camel@jaguar>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Fri, 17 Jun 2011 22:47:39 +0300, Pekka Enberg <penberg@kernel.org> wrote:
> On Fri, 2011-06-17 at 15:45 -0400, Sasha Levin wrote:
> > On Fri, 2011-06-17 at 23:41 +0530, Aneesh Kumar K.V wrote:
> > > Otherwise many things can break, such as mapping of stat to stat64
> > 
> > We always include our headers before system headers to make sure we
> > don't have any hidden prerequisites or dependencies within the headers.
> > 
> > Why did you need to move system headers before our headers in this case?
> 
> The stat64() breakage seems rather odd since we do this in the Makefile:
> 
> DEFINES	+= -D_FILE_OFFSET_BITS=64
> DEFINES	+= -D_GNU_SOURCE
> 
> Aneesh, what kind of build problems are you seeing?

Ok the below change also fix the issue for me. So it could be some
mapping in the kernel headers

diff --git a/tools/kvm/virtio/9p.c b/tools/kvm/virtio/9p.c
index 38a997d..730f4a1 100644
--- a/tools/kvm/virtio/9p.c
+++ b/tools/kvm/virtio/9p.c
@@ -9,16 +9,16 @@
 #include "kvm/threadpool.h"
 #include "kvm/irq.h"
 
-#include <linux/virtio_ring.h>
-#include <linux/virtio_9p.h>
-#include <net/9p/9p.h>
-
 #include <fcntl.h>
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <pthread.h>
 #include <dirent.h>
 
+#include <linux/virtio_ring.h>
+#include <linux/virtio_9p.h>
+#include <net/9p/9p.h>
+
 #define NUM_VIRT_QUEUES		1
 #define VIRTIO_P9_QUEUE_SIZE	128
 #define	VIRTIO_P9_TAG		"kvm_9p"