From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NJ6ymi2+" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B568129 for ; Fri, 1 Dec 2023 02:52:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701427965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9WB/DrQbi3LPDzD90+cir5HMSCD/2WMQTN7AHc14k3Q=; b=NJ6ymi2+JtCc9ao7ByKGvVjIVpC/ttuP+e6LZCTddwND5Juc5ou/AgUqhEuStOSIHsqKui WuGJAVGMohjbe/pOQsYt6oTYg09Osjcb9FeH4bWNXsq2Axi14RW3M3ffQRdOv7WGH/r8+L xblIpViFiex4dUKs0lF86IfVFsdYkoU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-352-P4sm2rC3N0K-pLezUbXi4g-1; Fri, 01 Dec 2023 05:52:42 -0500 X-MC-Unique: P4sm2rC3N0K-pLezUbXi4g-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 950618007B3; Fri, 1 Dec 2023 10:52:41 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.148]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6FBA02166B26; Fri, 1 Dec 2023 10:52:41 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 665FC21E6A1F; Fri, 1 Dec 2023 11:52:40 +0100 (CET) From: Markus Armbruster To: Xiaoyao Li Cc: Paolo Bonzini , David Hildenbrand , Igor Mammedov , "Michael S . Tsirkin" , Marcel Apfelbaum , Richard Henderson , Peter Xu , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Cornelia Huck , Daniel P . =?utf-8?Q?Berrang=C3=A9?= , Eric Blake , Markus Armbruster , Marcelo Tosatti , qemu-devel@nongnu.org, kvm@vger.kernel.org, Michael Roth , Sean Christopherson , Claudio Fontana , Gerd Hoffmann , Isaku Yamahata , Chenyi Qiang Subject: Re: [PATCH v3 13/70] i386: Introduce tdx-guest object References: <20231115071519.2864957-1-xiaoyao.li@intel.com> <20231115071519.2864957-14-xiaoyao.li@intel.com> Date: Fri, 01 Dec 2023 11:52:40 +0100 In-Reply-To: <20231115071519.2864957-14-xiaoyao.li@intel.com> (Xiaoyao Li's message of "Wed, 15 Nov 2023 02:14:22 -0500") Message-ID: <87ttp2w5xj.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 Xiaoyao Li writes: > Introduce tdx-guest object which implements the interface of > CONFIDENTIAL_GUEST_SUPPORT, and will be used to create TDX VMs (TDs) by > > qemu -machine ...,confidential-guest-support=tdx0 \ > -object tdx-guest,id=tdx0 > > It has only one member 'attributes' with fixed value 0 and not > configurable so far. > > Signed-off-by: Xiaoyao Li > Acked-by: Gerd Hoffmann > Acked-by: Markus Armbruster [...] > diff --git a/qapi/qom.json b/qapi/qom.json > index c53ef978ff7e..8e08257dac2f 100644 > --- a/qapi/qom.json > +++ b/qapi/qom.json > @@ -878,6 +878,16 @@ > 'reduced-phys-bits': 'uint32', > '*kernel-hashes': 'bool' } } > > +## > +# @TdxGuestProperties: > +# > +# Properties for tdx-guest objects. > +# > +# Since: 8.2 Going to be 9.0. > +## > +{ 'struct': 'TdxGuestProperties', > + 'data': { }} > + > ## > # @ThreadContextProperties: > # > @@ -956,6 +966,7 @@ > 'sev-guest', > 'thread-context', > 's390-pv-guest', > + 'tdx-guest', > 'throttle-group', > 'tls-creds-anon', > 'tls-creds-psk', > @@ -1022,6 +1033,7 @@ > 'secret_keyring': { 'type': 'SecretKeyringProperties', > 'if': 'CONFIG_SECRET_KEYRING' }, > 'sev-guest': 'SevGuestProperties', > + 'tdx-guest': 'TdxGuestProperties', > 'thread-context': 'ThreadContextProperties', > 'throttle-group': 'ThrottleGroupProperties', > 'tls-creds-anon': 'TlsCredsAnonProperties', [...]