From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH v3 1/9] arm64: KVM: rename pm_fake handler to trap_raz_wi Date: Wed, 09 Jul 2014 10:36:03 +0100 Message-ID: <87tx6q7u2k.fsf@why.wild-wind.fr.eu.org> References: <1403269207-1625-1-git-send-email-marc.zyngier@arm.com> <1403269207-1625-2-git-send-email-marc.zyngier@arm.com> <20140709092712.GA19801@cbox> Mime-Version: 1.0 Content-Type: text/plain Cc: "linux-arm-kernel\@lists.infradead.org" , "kvmarm\@lists.cs.columbia.edu" , "kvm\@vger.kernel.org" , Anup Patel To: Christoffer Dall Return-path: Received: from fw-tnat.austin.arm.com ([217.140.110.23]:34795 "EHLO collaborate-mta1.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751032AbaGIJgR (ORCPT ); Wed, 9 Jul 2014 05:36:17 -0400 In-Reply-To: <20140709092712.GA19801@cbox> (Christoffer Dall's message of "Wed, 9 Jul 2014 10:27:12 +0100") Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Jul 09 2014 at 10:27:12 am BST, Christoffer Dall wrote: > On Fri, Jun 20, 2014 at 01:59:59PM +0100, Marc Zyngier wrote: >> pm_fake doesn't quite describe what the handler does (ignoring writes >> and returning 0 for reads). >> >> As we're about to use it (a lot) in a different context, rename it >> with a (admitedly cryptic) name that make sense for all users. >> >> Reviewed-by: Anup Patel >> Signed-off-by: Marc Zyngier > > didn't I already review this? Did something change, it doesn't look > like it from the changelog.... > > /me confused. Nothing changed, just me forgetting to add your Reviewed-by tag. Sorry about that. M. -- Without deviation from the norm, progress is not possible.