From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BDB1E7D0A9 for ; Thu, 21 Sep 2023 19:29:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229685AbjIUT3w (ORCPT ); Thu, 21 Sep 2023 15:29:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230129AbjIUT31 (ORCPT ); Thu, 21 Sep 2023 15:29:27 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69B06A9EC for ; Thu, 21 Sep 2023 10:07:28 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06268C116D3; Thu, 21 Sep 2023 08:49:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695286186; bh=jBI4DDTzsnjvbT2OViCJyfEIRHKk7D4YO/h+LRCNpFk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ugp3m588JhNt/HGv0edk/kOhAp9E77T4Hq7x5Ym4IMtyo0u9vBM9nLksFdSodF8xS T3S3T2dUJXMi+h0gtVvtyiFRDw01l+G/qlbLNly+XOnXaS+frc6AS9Yc3qBeW9a22M rJsf4iyBtf1jpkaVVr+DYsqP9Dhz+mxW/aaXR+HVvMuYHBvtOsgp7dYqFJSu9n/8Y7 73sXd+xonoWiesTuoRsOG2tXJMUgZp4/yRmkmM2pBAcKzKVmpZsppkOzrIsVBgUToh 9uaWmW+30PhsUMj/+9RuKf5th1N1u8X3DCNCP4iNHVYyLle/xdLP+w/UDbQzed/EUa V5sNSQ97PH98g== Received: from 82-132-232-12.dab.02.net ([82.132.232.12] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qjFNX-00Esuq-EB; Thu, 21 Sep 2023 09:49:43 +0100 Date: Thu, 21 Sep 2023 09:49:40 +0100 Message-ID: <87v8c33o7v.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org, James Morse , Suzuki K Poulose , Zenghui Yu Subject: Re: [PATCH 0/8] KVM: arm64: Cleanup + fix to vCPU reset, feature flags In-Reply-To: <20230920195036.1169791-1-oliver.upton@linux.dev> References: <20230920195036.1169791-1-oliver.upton@linux.dev> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 82.132.232.12 X-SA-Exim-Rcpt-To: oliver.upton@linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, 20 Sep 2023 20:50:28 +0100, Oliver Upton wrote: > > The way we do vCPU feature flag checks is a bit of a scattered mess > between the KVM_ARM_VCPU_INIT ioctl handler and kvm_reset_vcpu(). Let's > move all the feature flag checks up into the ioctl() handler to > eliminate failure paths from kvm_reset_vcpu(), as other usage of this > function no not handle returned errors. > > Nobody screamed about the VM-wide feature flag change, so its also a > good time to rip out the vestiges of the vCPU-scoped bitmap. > > I also spotted a bug with the NV feature flag where we allow it > regardless of system support. Thanks for going the extra mile refactoring this stuff. Apart from the const/final nit, this looks good to me. It'd be good to have this in -next shortly. Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.