From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [PATCH 1/2] tools/kvm/9p: Always include system header before our headers
Date: Sat, 18 Jun 2011 12:18:18 +0530
Message-ID: <87vcw31vpp.fsf@linux.vnet.ibm.com>
References: <1308334282-11865-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1308339906.8711.13.camel@lappy> <1308340059.28516.3.camel@jaguar>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org
To: Pekka Enberg <penberg@kernel.org>,
	Sasha Levin <levinsasha928@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from e1.ny.us.ibm.com ([32.97.182.141]:50140 "EHLO e1.ny.us.ibm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750760Ab1FRGs0 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sat, 18 Jun 2011 02:48:26 -0400
Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233])
	by e1.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p5I6ab6Z009270
	for <kvm@vger.kernel.org>; Sat, 18 Jun 2011 02:36:37 -0400
Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p5I6mPvG125604
	for <kvm@vger.kernel.org>; Sat, 18 Jun 2011 02:48:25 -0400
Received: from d01av02.pok.ibm.com (loopback [127.0.0.1])
	by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p5I6mOrI022237
	for <kvm@vger.kernel.org>; Sat, 18 Jun 2011 03:48:25 -0300
In-Reply-To: <1308340059.28516.3.camel@jaguar>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Fri, 17 Jun 2011 22:47:39 +0300, Pekka Enberg <penberg@kernel.org> wrote:
> On Fri, 2011-06-17 at 15:45 -0400, Sasha Levin wrote:
> > On Fri, 2011-06-17 at 23:41 +0530, Aneesh Kumar K.V wrote:
> > > Otherwise many things can break, such as mapping of stat to stat64
> > 
> > We always include our headers before system headers to make sure we
> > don't have any hidden prerequisites or dependencies within the headers.
> > 
> > Why did you need to move system headers before our headers in this case?
> 
> The stat64() breakage seems rather odd since we do this in the Makefile:
> 
> DEFINES	+= -D_FILE_OFFSET_BITS=64
> DEFINES	+= -D_GNU_SOURCE
> 
> Aneesh, what kind of build problems are you seeing?

ubuntu natty x86_32 system. When you try to mount 9p you get "not a
directory" error, because virtio_p9_stat gets the stat value wrong
and virtio_p9_fill_stat don't find the export dir as a directory.

-aneesh