Re: [PATCH 1/2] tools/kvm/9p: Always include system header before our headers

Pekka Enberg
2011-06-17T19:47:41Z

On Fri, 2011-06-17 at 15:45 -0400, Sasha Levin wrote:
> On Fri, 2011-06-17 at 23:41 +0530, Aneesh Kumar K.V wrote:
> > Otherwise many things can break, such as mapping of stat to stat64
>
> We always include our headers before system headers to make sure we
> don't have any hidden prerequisites or dependencies within the headers.
>
> Why did you need to move system headers before our headers in this case?

The stat64() breakage seems rather odd since we do this in the Makefile:

DEFINES += -D_FILE_OFFSET_BITS=64
DEFINES += -D_GNU_SOURCE

Aneesh, what kind of build problems are you seeing?