Re: [PATCH 1/2] tools/kvm/9p: Always include system header before our headers

Aneesh Kumar K.V
2011-06-18T06:48:26Z

On Fri, 17 Jun 2011 22:47:39 +0300, Pekka Enberg <penberg@kernel.org> wrote:
> On Fri, 2011-06-17 at 15:45 -0400, Sasha Levin wrote:
> > On Fri, 2011-06-17 at 23:41 +0530, Aneesh Kumar K.V wrote:
> > > Otherwise many things can break, such as mapping of stat to stat64
> >
> > We always include our headers before system headers to make sure we
> > don't have any hidden prerequisites or dependencies within the headers.
> >
> > Why did you need to move system headers before our headers in this case?
>
> The stat64() breakage seems rather odd since we do this in the Makefile:
>
> DEFINES += -D_FILE_OFFSET_BITS=64
> DEFINES += -D_GNU_SOURCE
>
> Aneesh, what kind of build problems are you seeing?

ubuntu natty x86_32 system. When you try to mount 9p you get "not a
directory" error, because virtio_p9_stat gets the stat value wrong
and virtio_p9_fill_stat don't find the export dir as a directory.

-aneesh