Re: [PATCH 0/8] KVM: arm64: Cleanup + fix to vCPU reset, feature flags

Marc Zyngier
2023-09-21T19:29:49Z

On Wed, 20 Sep 2023 20:50:28 +0100,
Oliver Upton <oliver.upton@linux.dev> wrote:
>
> The way we do vCPU feature flag checks is a bit of a scattered mess
> between the KVM_ARM_VCPU_INIT ioctl handler and kvm_reset_vcpu(). Let's
> move all the feature flag checks up into the ioctl() handler to
> eliminate failure paths from kvm_reset_vcpu(), as other usage of this
> function no not handle returned errors.
>
> Nobody screamed about the VM-wide feature flag change, so its also a
> good time to rip out the vestiges of the vCPU-scoped bitmap.
>
> I also spotted a bug with the NV feature flag where we allow it
> regardless of system support.

Thanks for going the extra mile refactoring this stuff. Apart from the
const/final nit, this looks good to me. It'd be good to have this in
-next shortly.

Reviewed-by: Marc Zyngier <maz@kernel.org>

M.

--
Without deviation from the norm, progress is not possible.