From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D23DC43603 for ; Tue, 10 Dec 2019 06:53:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79CDC206D5 for ; Tue, 10 Dec 2019 06:53:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727322AbfLJGxO (ORCPT ); Tue, 10 Dec 2019 01:53:14 -0500 Received: from mga12.intel.com ([192.55.52.136]:17562 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727024AbfLJGxO (ORCPT ); Tue, 10 Dec 2019 01:53:14 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Dec 2019 22:53:14 -0800 X-IronPort-AV: E=Sophos;i="5.69,298,1571727600"; d="scan'208";a="203087366" Received: from wwisnei1-mobl.ger.corp.intel.com (HELO localhost) ([10.249.33.29]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Dec 2019 22:53:11 -0800 From: Jani Nikula To: Kirti Wankhede , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, kvm@vger.kernel.org Subject: Re: [PATCH v3 11/12] samples: vfio-mdev: constify fb ops In-Reply-To: <0d5434e0-3d86-bbb8-6377-94e00b4f0d78@nvidia.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <87tv694myu.fsf@intel.com> <0d5434e0-3d86-bbb8-6377-94e00b4f0d78@nvidia.com> Date: Tue, 10 Dec 2019 08:53:15 +0200 Message-ID: <87wob4vfhg.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, 10 Dec 2019, Kirti Wankhede wrote: > On 12/9/2019 7:31 PM, Jani Nikula wrote: >> On Tue, 03 Dec 2019, Jani Nikula wrote: >>> Now that the fbops member of struct fb_info is const, we can start >>> making the ops const as well. >>> >>> v2: fix typo (Christophe de Dinechin) >>> >>> Cc: Kirti Wankhede >>> Cc: kvm@vger.kernel.org >>> Reviewed-by: Daniel Vetter >>> Signed-off-by: Jani Nikula >> >> Kirti, may I have your ack to merge this through drm-misc please? >> >> BR, >> Jani. >> >>> --- >>> samples/vfio-mdev/mdpy-fb.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/samples/vfio-mdev/mdpy-fb.c b/samples/vfio-mdev/mdpy-fb.c >>> index 2719bb259653..21dbf63d6e41 100644 >>> --- a/samples/vfio-mdev/mdpy-fb.c >>> +++ b/samples/vfio-mdev/mdpy-fb.c >>> @@ -86,7 +86,7 @@ static void mdpy_fb_destroy(struct fb_info *info) >>> iounmap(info->screen_base); >>> } >>> >>> -static struct fb_ops mdpy_fb_ops = { >>> +static const struct fb_ops mdpy_fb_ops = { >>> .owner = THIS_MODULE, >>> .fb_destroy = mdpy_fb_destroy, >>> .fb_setcolreg = mdpy_fb_setcolreg, >> > > Acked-by : Kirti Wankhede Thanks, pushed to drm-misc-next. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center