From: Cornelia Huck <cohuck@redhat.com>
To: Eric Auger <eauger@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>,
Laurent Vivier <lvivier@redhat.com>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, kvm@vger.kernel.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Gavin Shan" <gshan@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>
Subject: Re: [PATCH v5 3/3] qtests/arm: add some mte tests
Date: Mon, 27 Feb 2023 16:16:42 +0100 [thread overview]
Message-ID: <87y1oj3zqd.fsf@redhat.com> (raw)
In-Reply-To: <87h6vt8rf3.fsf@redhat.com>
On Fri, Feb 10 2023, Cornelia Huck <cohuck@redhat.com> wrote:
> On Mon, Feb 06 2023, Eric Auger <eauger@redhat.com> wrote:
>
>> Hi,
>>
>> On 2/3/23 14:44, Cornelia Huck wrote:
>>> +static void mte_tests_default(QTestState *qts, const char *cpu_type)
>>> +{
>>> + assert_has_feature(qts, cpu_type, "mte");
>>> +
>>> + /*
>>> + * Without tag memory, mte will be off under tcg.
>>> + * Explicitly enabling it yields an error.
>>> + */
>>> + assert_set_feature_str(qts, "max", "mte", "off", "{ 'mte': 'off' }");
>>> + assert_error(qts, cpu_type, "mte=on requires tag memory",
>>> + "{ 'mte': 'on' }");
>> Sorry in v4 I reported I preferred the pauth msg, clarifying now:
>>
>> assert_error(qts, cpu_type, "cannot enable pauth-impdef without pauth",
>> "{ 'pauth': false, 'pauth-impdef': true }");
>>
>> Here would translate into cannot enable mte without tag memory.
>
> Oh, so you mean that I should adapt the message generated by the code?
Friendly ping :) Did you mean to adapt the error messages in cpu64.c?
next prev parent reply other threads:[~2023-02-27 15:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 13:44 [PATCH v5 0/3] arm: enable MTE for QEMU + kvm Cornelia Huck
2023-02-03 13:44 ` [PATCH v5 1/3] arm/virt: don't try to spell out the accelerator Cornelia Huck
2023-02-03 19:32 ` Richard Henderson
2023-02-06 12:46 ` Eric Auger
2023-02-03 13:44 ` [PATCH v5 2/3] arm/kvm: add support for MTE Cornelia Huck
2023-02-03 20:40 ` Richard Henderson
2023-02-06 13:10 ` Eric Auger
2023-02-06 16:15 ` Cornelia Huck
2023-02-27 15:12 ` Cornelia Huck
2023-02-06 16:41 ` Cornelia Huck
2023-02-06 13:32 ` Eric Auger
2023-02-06 18:27 ` Richard Henderson
2023-02-15 10:36 ` Eric Auger
2023-02-27 15:11 ` Cornelia Huck
2023-02-03 13:44 ` [PATCH v5 3/3] qtests/arm: add some mte tests Cornelia Huck
2023-02-06 18:23 ` Eric Auger
2023-02-10 15:35 ` Cornelia Huck
2023-02-27 15:16 ` Cornelia Huck [this message]
2023-02-15 10:59 ` Cornelia Huck
2023-02-16 17:30 ` Eric Auger
2023-02-16 11:40 ` [PATCH v5 0/3] arm: enable MTE for QEMU + kvm Peter Maydell
2023-02-16 11:46 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1oj3zqd.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eauger@redhat.com \
--cc=gshan@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).